Skip to content

Commit

Permalink
Remove hardcoded non trimmable assemblies in oob.proj
Browse files Browse the repository at this point in the history
Fixes #72166

Use the `TargetPathWithTargetPlatformMoniker` to flow through the IsTrimmable property that is set by projects and use that for illink validation assembly selection.
  • Loading branch information
ViktorHofer authored Jul 14, 2022
1 parent 1a0c9ca commit 871e197
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions eng/illink.targets
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@
<!-- ApiCompat should perform compatibility checks on the trimmed assemblies. -->
<ApiCompatDependsOn>$(ApiCompatDependsOn);ILLinkTrimAssembly</ApiCompatDependsOn>
</PropertyGroup>

<!-- Flow the IsTrimmable property down to consuming repositories, in order for oob.proj
to exclude non trimmable assemblies. -->
<ItemDefinitionGroup>
<TargetPathWithTargetPlatformMoniker>
<IsTrimmable>$(IsTrimmable)</IsTrimmable>
</TargetPathWithTargetPlatformMoniker>
</ItemDefinitionGroup>

<!-- Inputs and outputs of ILLinkTrimAssembly -->
<PropertyGroup>
Expand Down

0 comments on commit 871e197

Please sign in to comment.