-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TrimOOBAssemblies target shouldn't hardcode untrimmable assemblies #72166
Comments
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsThe runtime/src/libraries/oob.proj Lines 48 to 59 in f0a7566
This information is already provided by the projects themselves and should just be accessed by flowing it through the runtime/eng/references.targets Lines 71 to 75 in f0a7566
cc @eerhardt @joperezr @ericstj
|
Fixes #72166 Use the `TargetPathWithTargetPlatformMoniker` to flow through the IsTrimmable property that is set by projects and use that for illink validation assembly selection.
* Remove hardcoded non trimmable assemblies in oob.proj Fixes #72166 Use the `TargetPathWithTargetPlatformMoniker` to flow through the IsTrimmable property that is set by projects and use that for illink validation assembly selection. * Update oob.proj * Update illink.targets
The
TrimOOBAssemblies
's dependent target currently hardcodes the list of untrimmable out-of-band assemblies:runtime/src/libraries/oob.proj
Lines 48 to 59 in f0a7566
This information is already provided by the projects themselves and should just be accessed by flowing it through the
TargetPathWithTargetPlatformMoniker
item. That static data isn't up-to-date already asSystem.ComponentModel.AttributedModel
andSystem.Composition.Runtime
are trimmable but were excluded from the validation.Noticed this in https://github.com/dotnet/runtime/pull/71752/files#diff-c45d29e8d7bee20b15b64ce806983857a3e5899cbedc412e71cce4bd83a70323R58 which sets
<IsTrimmable>false</IsTrimmable>
in the project's body but also in the oob.proj file.cc @eerhardt @joperezr @ericstj
The text was updated successfully, but these errors were encountered: