Skip to content

Commit

Permalink
[wasm] Fix reference to Microsoft.Build.NoTargets (#75472)
Browse files Browse the repository at this point in the history
.. in `WasmTestRunner.proj` used for runtime tests.

This project requires an explicit SDK version number because it is used
on Helix, and `global.json` is not available there. The version matches what we
have in `global.json`.

```
  Starting:    Loader.classloader.XUnitWrapper (parallel test collections = on, max threads = 2)
    Loader/classloader/DefaultInterfaceMethods/genericmethods/genericmethods/genericmethods.sh [FAIL]

...

      /datadisks/disk1/work/C25609EE/p/wasm-test-runner/WasmTestRunner.proj : error : Failed to resolve SDK 'Microsoft.Build.NoTargets/1.0.53'. Package restore was successful but a package with the ID of "Microsoft.Build.NoTargets" was not installed.
      /datadisks/disk1/work/C25609EE/p/wasm-test-runner/WasmTestRunner.proj : error MSB4236: The SDK 'Microsoft.Build.NoTargets/1.0.53' specified could not be found.
```
  • Loading branch information
radical committed Sep 13, 2022
1 parent 559d9e7 commit a7da979
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/tests/Common/wasm-test-runner/WasmTestRunner.proj
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<!-- This project requires an explicit SDK version number because it is used on Helix,
and global.json is not available. -->
<Project Sdk="Microsoft.Build.NoTargets/1.0.53" DefaultTargets="WasmBuildApp">
<Project Sdk="Microsoft.Build.NoTargets/3.5.0" DefaultTargets="WasmBuildApp">
<Import Project="$(CORE_ROOT)\build\WasmApp.InTree.props" />
<PropertyGroup>
<EnableDefaultCompileItems>false</EnableDefaultCompileItems>
Expand Down

0 comments on commit a7da979

Please sign in to comment.