[release/7.0][wasm] Fix reference to Microsoft.Build.NoTargets
#75472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. in `WasmTestRunner.proj` used for runtime tests.
This project requires an explicit SDK version number because it is used
on Helix, and `global.json` is not available there. The version matches what we
have in `global.json`.
```
Starting: Loader.classloader.XUnitWrapper (parallel test collections = on, max threads = 2)
Loader/classloader/DefaultInterfaceMethods/genericmethods/genericmethods/genericmethods.sh [FAIL]
...
/datadisks/disk1/work/C25609EE/p/wasm-test-runner/WasmTestRunner.proj : error : Failed to resolve SDK 'Microsoft.Build.NoTargets/1.0.53'. Package restore was successful but a package with the ID of "Microsoft.Build.NoTargets" was not installed.
/datadisks/disk1/work/C25609EE/p/wasm-test-runner/WasmTestRunner.proj : error MSB4236: The SDK 'Microsoft.Build.NoTargets/1.0.53' specified could not be found.
```
ghost
assigned 
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBackport of the fix from #75397 Customer impactNone. This is a tests only change. TestingCI RiskNone, as long as the tests pass
|
steveisok
approved these changes
Sep 12, 2022
lewing
approved these changes
Sep 12, 2022
marek-safar
approved these changes
Sep 13, 2022
|
@carlossanlop ready for merge |
Let's do this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of the fix from #75397
Customer impact
None. This is a tests only change.
Testing
CI
wasm runtimetestsrun, since this is a CI/tests only change.Risk
None, as long as the tests pass