Mark XxHash64.Complete as noinline (#90142)

dotnet · Aug 8, 2023 · bcf9938 · bcf9938
1 parent 749b2d2
commit bcf9938
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/libraries/System.IO.Hashing/src/System/IO/Hashing/XxHash64.State.cs b/src/libraries/System.IO.Hashing/src/System/IO/Hashing/XxHash64.State.cs
@@ -97,6 +97,10 @@ private static ulong ApplyRound(ulong acc, ulong lane)
                 return acc;
             }
 
+            // Inliner may decide to inline this method into HashToUInt64() with help of PGO and
+            // can run out of "time budget" producing non-inlined simple calls such as Span.Slice.
+            // TODO: Remove NoInlining when https://github.com/dotnet/runtime/issues/85531 is fixed.
+            [MethodImpl(MethodImplOptions.NoInlining)]
             internal readonly ulong Complete(long length, ReadOnlySpan<byte> remaining)
             {
                 ulong acc = _hadFullStripe ? Converge() : _smallAcc;