Mark XxHash64.Complete as noinline #90142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90090
Temp workaround for the inliner's budget problem. It seems to decide to inline this function because it's on a hot path + PGO + it has multiple recognizeable intrinsics and looks like it mistakenly recognized foldable expressions here. Actually, it does make code faster if we inline it, but, since we run out of budget, we give up on inlining simple things such as
Span.Slice
and that makes perf worse. No impact on large inputs as the main work is done in this loop and Complete is called as the last iteration so only small inputs are affected..It's not an issue for
XxHash32
whereComplete()
is 2x simpler and is inlined just fine.XxHash128
is not affected as well due to a different structure of code, although, it hit a similiar issue in the past.