Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark XxHash64.Complete as noinline #90142

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Mark XxHash64.Complete as noinline #90142

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f51f81
Mark XxHash.Complete as noinline
EgorBo Aug 8, 2023
5868a10
revert xxhash32
EgorBo Aug 8, 2023
990bfdc
Add comment
EgorBo Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/libraries/System.IO.Hashing/src/System/IO/Hashing/XxHash64.State.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@ private static ulong ApplyRound(ulong acc, ulong lane)
return acc;
}

// Inliner may decide to inline this method into HashToUInt64() with help of PGO and
// can run out of "time budget" producing non-inlined simple calls such as Span.Slice.
// TODO: Remove NoInlining when https://github.com/dotnet/runtime/issues/85531 is fixed.
[MethodImpl(MethodImplOptions.NoInlining)]
EgorBo marked this conversation as resolved.
Show resolved Hide resolved
internal readonly ulong Complete(long length, ReadOnlySpan<byte> remaining)
{
ulong acc = _hadFullStripe ? Converge() : _smallAcc;
Expand Down