Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look at method alignment with OptimizationPreference=Size and ControlFlowGuard=Guard #105326

Closed
MichalStrehovsky opened this issue Jul 23, 2024 · 1 comment · Fixed by #106132
Closed

Look at method alignment with OptimizationPreference=Size and ControlFlowGuard=Guard #105326

MichalStrehovsky opened this issue Jul 23, 2024 · 1 comment · Fixed by #106132
Labels
area-NativeAOT-coreclr in-pr There is an active PR which will close this issue when it is merged
Milestone
9.0.0

Comments

@MichalStrehovsky
Copy link
Member

We might be aligning at 4 bytes when we should be aligning at 16 bytes for CFG.
@MichalStrehovsky MichalStrehovsky added this to the 9.0.0 milestone Jul 23, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

MichalStrehovsky added a commit to MichalStrehovsky/runtime that referenced this issue Aug 8, 2024
@MichalStrehovsky
Align methods at 16-byte boundaries for CFG
a06c713 
Fixes dotnet#105326

Per https://learn.microsoft.com/en-us/windows/win32/secbp/pe-metadata#function-alignment "Functions that are address taken and are therefore included in the GFIDS table should be made 16-byte aligned, if possible.". We'd align at 4 bytes if SIZE_OPT is enabled.
@MichalStrehovsky MichalStrehovsky mentioned this issue Aug 8, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Aug 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-NativeAOT-coreclr in-pr There is an active PR which will close this issue when it is merged
Projects
AppModel
Archived in project
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Align methods at 16-byte boundaries for CFG MichalStrehovsky/runtime
1 participant
@MichalStrehovsky