Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake doesn't find brotli modules when building with CLR_CMAKE_USE_SYSTEM_BROTLI #109105

Closed
tmds opened this issue Oct 22, 2024 · 1 comment
Closed

Comments

@tmds
Copy link
Member

tmds commented Oct 22, 2024

The command:

./build.sh /p:NoPgoOptimize=true --portablebuild false /p:DotNetBuildFromSource=true /p:DotNetBuildSourceOnly=true /p:DotNetBuildTests=true --cmakeargs -DCLR_CMAKE_USE_SYSTEM_BROTLI=true --cmakeargs -DCLR_CMAKE_USE_SYSTEM_LIBUNWIND=true --cmakeargs -DCLR_CMAKE_USE_SYSTEM_RAPIDJSON=true --cmakeargs -DCLR_CMAKE_USE_SYSTEM_ZLIB=true --runtimeconfiguration Release --librariesConfiguration Debug --subset clr+libs+host+packs+libs.tests

Fails with:

  -- Checking for modules 'brotlidec;brotlienc;brotlicommon'
  --   Package 'brotlidec', required by 'virtual:world', not found
  --   Package 'brotlienc', required by 'virtual:world', not found
  --   Package 'brotlicommon', required by 'virtual:world', not found
  CMake Error at /usr/share/cmake/Modules/FindPkgConfig.cmake:607 (message):
    A required package was not found
  Call Stack (most recent call first):
    /usr/share/cmake/Modules/FindPkgConfig.cmake:829 (_pkg_check_modules_internal)
    /var/home/tmds/repos/runtime/src/native/libs/System.IO.Compression.Native/CMakeLists.txt:11 (pkg_check_modules)

This regressed in #107166.

The system libs configuration isn't exercised in CI which is why the build issue went unnoticed.

@jkoritzinsky can you please take a look?

cc @omajid @MichaelSimons

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 22, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Oct 22, 2024
@jkotas jkotas added area-System.IO.Compression and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 22, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

jkoritzinsky added a commit to jkoritzinsky/runtime that referenced this issue Nov 11, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Dec 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants