-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put brotli on the FetchContent plan #107166
Conversation
…ia CMake's PkgConfig model
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Windows.targets
Show resolved
Hide resolved
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets
Outdated
Show resolved
Hide resolved
@jkoritzinsky let me know when the PR is "ready", and then I will locally backport it to 9.0 and do some .NET builds to verify it fixes #107020. |
…ompression.Native.
…y default (doesn't work on wasi)
…st brotlicommon instead of dynamically linked against it.
…veAOT build for mono Apple scenarios.
@akoeplinger @jkotas should we keep using the system brotli in mobile platforms and wasi/wasm like we did with zlib-ng? Why or why not? |
Does the system brotli exist on these platforms? Do we use it today? |
I do not know if system brotli exists in those platforms but we do use it today with |
We do not set I think that system brotli does not exist on those platforms and we should be doing what we have been doing so far ie. use our bundled one. There is no other option. |
…ses (thanks single-pass linker ordering...)
/azp run runtime-community, runtime-extra-platforms, runtime-nativeaot-outerloop |
Azure Pipelines successfully started running 3 pipeline(s). |
All failures look unrelated. Looks like we're good to go here! |
This reverts commit a7fc1ea.
This reverts commit a7fc1ea. It broke the official build with an arch variant of `bin/native/net10.0-linux-Release-arm/libbrotlicommon.a' is not added because the package already contains file 'runtimes/linux-arm/native/libbrotlicommon.a`
Consume our brotli dependency through FetchContent like zlib-ng. Also, update the "system brotli" consumption to use CMake's PkgConfig support. This provides us with a few benefits:
nonportable.txt
workaround as we have files on disk we can look for, just like zlib-ng.Fixes #107020