Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Linux/arm] JIT/Directed/coverage/importer/Desktop/byrefsubbyref1_il_{r,d} fail with COMPlus_JitELTHookEnabled=1 #13355

Closed
echesakov opened this issue Sep 3, 2019 · 1 comment · Fixed by #38855
Closed

[Linux/arm] JIT/Directed/coverage/importer/Desktop/byrefsubbyref1_il_{r,d} fail with COMPlus_JitELTHookEnabled=1 #13355

echesakov opened this issue Sep 3, 2019 · 1 comment · Fixed by #38855
Assignees
@sandreenko
Labels
arch-arm32 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-linux Linux OS (any supported distro)
Milestone
5.0.0

Comments

@echesakov
Copy link
Contributor

It's the same issue as the one I saw on Linux/arm64 (dotnet/coreclr#26460 (comment))

      JIT/Directed/coverage/importer/Desktop/byrefsubbyref1_il_r/byrefsubbyref1_il_r.sh [FAIL]                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              Assert failure(PID 2215 [0x000008a7], Thread: 2215 [0x08a7]): Assertion failed '!"Incompatible types for gtNewTempAssign"' in 'a:byrefsubi4(byref,int):int' (IL size 10)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                File: /opt/code/src/jit/gentree.cpp Line: 14568                                                                                                                                                                                                                                                                                                           Image: /mnt/echesakov/coreclr/bin/tests/Linux.arm.Checked/Tests/Core_Root/corerun                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               /mnt/echesakov/coreclr/bin/tests/Linux.arm.Checked/JIT/Directed/coverage/importer/Desktop/byrefsubbyref1_il_r/byrefsubbyref1_il_r.sh: line 252:  2215 Aborted                 $LAUNCHER $ExePath "${CLRTestExecutionArguments[@]}"                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  Return code:      1                                                                                                                                                                                                                                                                                                                                       Raw output file:      /mnt/echesakov/coreclr/bin/tests/Linux.arm.Checked/JIT/Directed/Reports/JIT.Directed/coverage/importer/Desktop/byrefsubbyref1_il_r/byrefsubbyref1_il_r.output.txt                                                                                                                                                                   Raw output:                                                                                                                                                                                                                                                                                                                                               BEGIN EXECUTION                                                                                                                                                                                                                                                                                                                                           /mnt/echesakov/coreclr/bin/tests/Linux.arm.Checked/Tests/Core_Root/corerun byrefsubbyref1_il_r.dll ''                                                                                                                                                                                                                                                     -4                                                                                                                                                                                                                                                                                                                                                                       [000002] -----+-------             *  SUB       byref                                                                                                                                                                                                                                                                                                     [000000] -----+-------             +--*  LCL_VAR   byref  V00 arg0                                                                                                                                                                                                                                                                                        [000001] -----+-------             \--*  LCL_VAR   int    V01 arg1                                                                                                                                                                                                                                                                         Expected: 100                                                                                                                                                                                                                                                                                                                                             Actual: 134                                                                                                                                                                                                                                                                                                                                               END EXECUTION - FAILED                                                                                                                                                                                                                                                                                                                                    Test Harness Exitcode is : 1                                                                                                                                                                                                                                                                                                                              To run the test:                                                                                                                                                                                                                                                                                                                                          > set CORE_ROOT=/mnt/echesakov/coreclr/bin/tests/Linux.arm.Checked/Tests/Core_Root                                                                                                                                                                                                                                                                        > /mnt/echesakov/coreclr/bin/tests/Linux.arm.Checked/JIT/Directed/coverage/importer/Desktop/byrefsubbyref1_il_r/byrefsubbyref1_il_r.sh                                                                                                                                                                                                                    Expected: True                                                                                                                                                                                                                                                                                                                                            Actual:   False                                                                                                                                                                                                                                                                                                                                           Stack Trace:                                                                                                                                                                                                                                                                                                                                                /opt/code/bin/tests/Linux.arm.Checked/TestWrappers/JIT.Directed/JIT.Directed.XUnitWrapper.cs(10810,0): at JIT_Directed._coverage_importer_Desktop_byrefsubbyref1_il_r_byrefsubbyref1_il_r_._coverage_importer_Desktop_byrefsubbyref1_il_r_byrefsubbyref1_il_r_sh()                                                                                      Output:                                                                                                                                                                                                                                                                                                                                           
          Assert failure(PID 2215 [0x000008a7], Thread: 2215 [0x08a7]): Assertion failed '!"Incompatible types for gtNewTempAssign"' in 'a:byrefsubi4(byref,int):int' (IL size 10)

              File: /opt/code/src/jit/gentree.cpp Line: 14568
              Image: /mnt/echesakov/coreclr/bin/tests/Linux.arm.Checked/Tests/Core_Root/corerun

          /mnt/echesakov/coreclr/bin/tests/Linux.arm.Checked/JIT/Directed/coverage/importer/Desktop/byrefsubbyref1_il_r/byrefsubbyref1_il_r.sh: line 252:  2215 Aborted                 $LAUNCHER $ExePath "${CLRTestExecutionArguments[@]}"

          Return code:      1
          Raw output file:      /mnt/echesakov/coreclr/bin/tests/Linux.arm.Checked/JIT/Directed/Reports/JIT.Directed/coverage/importer/Desktop/byrefsubbyref1_il_r/byrefsubbyref1_il_r.output.txt
          Raw output:
          BEGIN EXECUTION
          /mnt/echesakov/coreclr/bin/tests/Linux.arm.Checked/Tests/Core_Root/corerun byrefsubbyref1_il_r.dll ''
          -4
                         [000002] -----+-------             *  SUB       byref
                         [000000] -----+-------             +--*  LCL_VAR   byref  V00 arg0
                         [000001] -----+-------             \--*  LCL_VAR   int    V01 arg1
          Expected: 100
          Actual: 134
          END EXECUTION - FAILED
          Test Harness Exitcode is : 1
          To run the test:
          > set CORE_ROOT=/mnt/echesakov/coreclr/bin/tests/Linux.arm.Checked/Tests/Core_Root
          > /mnt/echesakov/coreclr/bin/tests/Linux.arm.Checked/JIT/Directed/coverage/importer/Desktop/byrefsubbyref1_il_r/byrefsubbyref1_il_r.sh

category:correctness
theme:elt-hooks
skill-level:intermediate
cost:medium
@echesakov echesakov changed the title [Linux/arm] JIT/Directed/coverage/importer/Desktop/byrefsubbyref1_il_r fail with COMPlus_JitELTHookEnabled=1 [Linux/arm] JIT/Directed/coverage/importer/Desktop/byrefsubbyref1_il_{r,d} fail with COMPlus_JitELTHookEnabled=1 Sep 3, 2019
echesakov referenced this issue in dotnet/coreclr Oct 14, 2019
@echesakov
Add regression test for https://github.com/dotnet/coreclr/issues/26491 (
45a1369 
#26518)
@sandreenko
Copy link
Contributor

Link dotnet/coreclr#26518

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the 5.0 milestone Jan 31, 2020
@BruceForstall BruceForstall self-assigned this Apr 29, 2020
sandreenko pushed a commit to sandreenko/runtime that referenced this issue Jul 7, 2020
Reenable GitHub_26491.
b30dabd 
Closes dotnet#13355
@sandreenko sandreenko mentioned this issue Jul 7, 2020
Merged
sandreenko pushed a commit that referenced this issue Jul 8, 2020
Reenable fixed tests after noRetyping and similar changes. (#38855)
9bb997b 
* Reenable GitHub_26491.

Closes #13355

* Reenable crossgen2 tests failing with old retyping/

They were fixed both with and without retyping.
Closes #37883.

* Reenable HVA merge cases.

Closes #37341, closes #37880.

* Reenable GitHub_35821.

Closes #36206, closes #36418.

The issue was fixed by #37499.

* Delete extra lines that are no longer needed.

#37506 was fixed in #38241.

* delete a throwing init.
@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandreenko sandreenko

Labels
arch-arm32 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-linux Linux OS (any supported distro)
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Reenable fixed tests after noRetyping and similar changes. sandreenko/runtime
4 participants
@echesakov @msftgits @BruceForstall @sandreenko