Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable fixed tests after noRetyping and similar changes. #38855

Merged
merged 6 commits into from
Jul 8, 2020

Conversation

sandreenko
Copy link
Contributor

@sandreenko sandreenko commented Jul 7, 2020

b30dabd: Reenable GitHub_26491.

Closes #13355.

5ae2554: Reenable crossgen2 tests failing with old retyping/

They were fixed both with and without retyping.
Closes #37883.

b4faef4: Reenable HVA merge cases.

Closes #37341, closes #37880.

c31f691: Reenable GitHub_35821.

Closes #36206, closes #36418.

The issue was fixed by #37499.

f483441: Delete extra lines that are no longer needed.

#37506 was fixed in #38241.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 7, 2020
@sandreenko sandreenko added the disabled-test The test is disabled in source code against the issue label Jul 7, 2020
@sandreenko sandreenko marked this pull request as ready for review July 7, 2020 23:21
@sandreenko
Copy link
Contributor Author

PTAL @dotnet/jit-contrib
I have tested them locally so don't see much value in running additional legs here.

Copy link
Contributor

@CarolEidt CarolEidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for following up

@sandreenko sandreenko merged commit 9bb997b into dotnet:master Jul 8, 2020
@sandreenko sandreenko deleted the reenableFixedTests branch July 8, 2020 07:47
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.