Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup System.Runtime.Tests #16433

Closed
21 tasks done
hughbe opened this issue Feb 21, 2016 · 4 comments
Closed
21 tasks done

Cleanup System.Runtime.Tests #16433

hughbe opened this issue Feb 21, 2016 · 4 comments
Assignees
Milestone

Comments

@hughbe
Copy link
Contributor

hughbe commented Feb 21, 2016

This is a meta-issue to track progress on cleaning up System.Runtime.Tests. I dumped a massive PR (#5490) which I'm splitting up into smaller ones
The following test files should be cleaned up, to add additional coverage, and follow test guidelines better:

After this:

@hughbe
Copy link
Contributor Author

hughbe commented Feb 21, 2016

@stephentoub I've sent in 8 PRs for this. I don't want to spam your pull requests page so I'm going to hold off until some of those are reviewed and merged ;)

@stephentoub stephentoub reopened this Feb 22, 2016
krytarowski referenced this issue in krytarowski/corefx Mar 5, 2016
- Add mising tests (espcially for invalid arguments)

Contributes to #6286
krytarowski referenced this issue in krytarowski/corefx Mar 5, 2016
- Add mising tests (espcially for invalid arguments)

Contributes to #6286
@jamesqo
Copy link
Contributor

jamesqo commented Mar 13, 2016

Shouldn't this issue be open? It looks like GitHub may have detected the words 'fix dotnet/corefx#6286' in 652cbda and automatically closed this.

@hughbe
Copy link
Contributor Author

hughbe commented Mar 13, 2016 via email

@hughbe
Copy link
Contributor Author

hughbe commented Apr 9, 2016

Brilliant. I've submitted all the PRs now for this cleanup! Sorry for dumping 10 PRs or so today ;)

stephentoub referenced this issue in dotnet/corefx Apr 9, 2016
* Cleanup misc runtime test

Contributes to #6286
Cherry picked from #5490
stephentoub referenced this issue in dotnet/corefx Apr 9, 2016
* Cleanup System.*Exception tests

- Rename and cleanup tests

Contributes to #6286
stephentoub referenced this issue in dotnet/corefx Apr 9, 2016
* Cleanup System.IO.*Exception tests

- Take advantage of xunit
- Refactor tests to be more readable

Contributes to #6286
stephentoub referenced this issue in dotnet/corefx Apr 10, 2016
* Cleanup char tests

- Take advantage of xunit
- Split up some tests to ensure tests only test a single thing

Contributes to #6286
stephentoub referenced this issue in dotnet/corefx Apr 10, 2016
* Cleanup Buffer tests

- Take advantage of xunit
- Add some missing tests

Contributes to #6286
stephentoub referenced this issue in dotnet/corefx Apr 15, 2016
* Cleanup Lazy tests

- Split up long tests
- Add tests (mainly for invalid constructors)

Contributes to #6286
stephentoub referenced this issue in dotnet/corefx Apr 20, 2016
* Cleanup Single (Float) and Double tests

- Take advantage of xunit
- Add negative tests for Parse (as per a TODO)
- Refactor tests for ToString()

Contributes to #6286
Cherry picked from #5490
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 1.0.0-rtm milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants