Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete special casing around non-virtual calls to abstract interface methods #37400

Closed
MichalStrehovsky opened this issue Jun 4, 2020 · 2 comments · Fixed by #38564
Closed

Delete special casing around non-virtual calls to abstract interface methods #37400

MichalStrehovsky opened this issue Jun 4, 2020 · 2 comments · Fixed by #38564
Assignees
@nattress
Labels
area-crossgen2-coreclr
Milestone
5.0.0

Comments

@MichalStrehovsky
Copy link
Member

Port dotnet/coreclr#23032 to crossgen2.

The comment // Backwards compat: calls to abstract interface methods are treated as callvirt is still present in crossgen2's JitInterface implementation.

Noticed because #37370 was touching nearby lines.

Weird that the test is not failing (?).
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jun 4, 2020
@mangod9 mangod9 removed the untriaged New issue has not been triaged by the area owner label Jun 5, 2020
@mangod9 mangod9 added this to the 5.0 milestone Jun 5, 2020
@mangod9
Copy link
Member

mangod9 commented Jun 5, 2020

is this fixed after @nattress recent change?

@MichalStrehovsky
Copy link
Member Author

No, that line is about a dozen lines above Simon's change. I just didn't want to pester him with one more unrelated thing.

nattress added a commit to nattress/runtime that referenced this issue Jun 29, 2020
@nattress
[Crossgen2] Remove legacy behavior around non-virtual interface calls
73a0daa 
Resolves dotnet#37400

The regression test was not failing in Crossgen2 because somewhere along the way when we eyeball ported `getCallInfo` the ordering of these two if block was switched, so Crossgen2 was always treating such calls as non-virtual.
@nattress nattress mentioned this issue Jun 29, 2020
Merged
nattress added a commit that referenced this issue Jun 29, 2020
@nattress
[Crossgen2] Remove legacy behavior around non-virtual interface calls (…
3d988b5 
…#38564)

Resolves #37400

The regression test was not failing in Crossgen2 because somewhere along the way when we eyeball ported `getCallInfo` the ordering of these two if block was switched, so Crossgen2 was always treating such calls as non-virtual.
kevinwkt pushed a commit to kevinwkt/runtimelab that referenced this issue Jul 15, 2020
@nattress @kevinwkt
[Crossgen2] Remove legacy behavior around non-virtual interface calls…
535e675 
… (#38564)

Resolves dotnet/runtime#37400

The regression test was not failing in Crossgen2 because somewhere along the way when we eyeball ported `getCallInfo` the ordering of these two if block was switched, so Crossgen2 was always treating such calls as non-virtual.
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nattress nattress

Labels
area-crossgen2-coreclr
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

[Crossgen2] Remove legacy behavior around non-virtual interface calls nattress/runtime
4 participants
@nattress @MichalStrehovsky @Dotnet-GitSync-Bot @mangod9