Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Enable crypto and related tests #37669

Closed
Tracked by #64488
steveisok opened this issue Jun 9, 2020 · 9 comments
Closed
Tracked by #64488

[wasm] Enable crypto and related tests #37669

steveisok opened this issue Jun 9, 2020 · 9 comments
Assignees
@radical @pavelsavara
Labels
arch-wasm WebAssembly architecture area-System.Security
Milestone
7.0.0

Comments

@steveisok
Copy link
Member

The crypto tests are currently disabled since we are not shipping Wasm w/ openssl and interop w/ SubtleCrypto is not currently possible. Reasoning being, some of our .NET crypto API's are sync and all SubtleCrypto is async.

As of right now, something like Asyncify will not work for us either, but it's something we should continue to pay attention to.
@steveisok steveisok added arch-wasm WebAssembly architecture area-System.Security labels Jun 9, 2020
@ghost
Copy link

ghost commented Jun 9, 2020

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq
Notify danmosemsft if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jun 9, 2020
@MaximLipnin MaximLipnin mentioned this issue Jun 25, 2020
Merged
akoeplinger pushed a commit that referenced this issue Jun 29, 2020
@MaximLipnin
Add throwing PNSE to System.Security.Cryptography on WASM (#38379)
522d73e 
Since the entire set of System.Security.Cryptography.* tests has been disabled on WASM recently in #37723, we need to let everyone know that those areas are not quite supported on WASM at the moment. In that case System.Security.Cryptography classes could throw PlatformNotSupportedException until some solution comes (#37669)
@marek-safar marek-safar removed the untriaged New issue has not been triaged by the area owner label Jun 30, 2020
@marek-safar marek-safar added this to the 6.0.0 milestone Jun 30, 2020
@steveisok steveisok changed the title [wasm] Enable crypto tests [wasm] Enable crypto and related tests Jul 2, 2020
kevinwkt pushed a commit to kevinwkt/runtimelab that referenced this issue Jul 15, 2020
@MaximLipnin @kevinwkt
Add throwing PNSE to System.Security.Cryptography on WASM (#38379)
d06f134 
Since the entire set of System.Security.Cryptography.* tests has been disabled on WASM recently in dotnet/runtime#37723, we need to let everyone know that those areas are not quite supported on WASM at the moment. In that case System.Security.Cryptography classes could throw PlatformNotSupportedException until some solution comes (dotnet/runtime#37669)
@steveisok steveisok mentioned this issue Aug 3, 2020
Open
@eerhardt eerhardt mentioned this issue Aug 17, 2020
Merged
@akoeplinger akoeplinger mentioned this issue Sep 2, 2020
Merged
@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this issue Feb 24, 2021
Closed
@elinor-fung elinor-fung mentioned this issue Apr 7, 2021
Merged
@pavelsavara
Copy link
Member

This document should be updated when we have the solution.
https://github.com/dotnet/runtime/blob/main/docs/design/features/cross-platform-cryptography.md

@pavelsavara pavelsavara mentioned this issue May 20, 2021
Merged
pavelsavara added a commit to pavelsavara/runtime that referenced this issue Jun 2, 2021
@pavelsavara
- run outerloop on browser, rather than V8 only
5efbadc 
- [ActiveIssue] dotnet#37669 for missing crypto MD5
pavelsavara added a commit that referenced this issue Jun 2, 2021
@pavelsavara
[wasm] Enable more networking tests (#53027)
1e19518 
- enable System.Net.Http.Functional.Tests on browser
- System.Net.Http.Functional.Tests to run in chrome instead of V8 via WasmTestOnBrowser
- ActiveIssue #34690 for WebSocket on Windows Mono
- fix Quic detection in test
- disable webSocket tests on Mono/Windows
- disable tests with MaxConnectionsPerServer not supported on Browser
- disable tests with Socket not supported on Browser
- disable tests with AutomaticDecompression not supported on Browser
- disable tests with UseProxy not supported on Browser
- disable tests with PreAuthenticate not supported on Browser
- disable tests with Credentials is not supported on Browser
- disable tests with Loopback server
- run outerloop on browser, rather than V8 only
- [ActiveIssue] #37669 for missing crypto MD5
- conditional tests with PlatformDetection.IsBrowserDomSupportedOrNotBrowser to allow System.Net.Http.Functional.Tests pass on V8
- disabled tests with #53018
- disabled tests with #53591
- disabled tests with #53592
This was referenced Jun 3, 2021
Merged
Merged
@pavelsavara pavelsavara mentioned this issue Jun 16, 2021
Merged
@lewing lewing modified the milestones: 6.0.0, 7.0.0 Jul 31, 2021
@bartonjs bartonjs mentioned this issue Nov 2, 2021
Merged
radical added a commit to radical/runtime that referenced this issue Nov 2, 2021
@radical
Use dotnet#37669 as the issue, based on feedback
a2a22a8
@radical radical mentioned this issue Nov 2, 2021
Closed
@jeffhandley jeffhandley mentioned this issue Jan 29, 2022
Closed
37 tasks
@radical radical mentioned this issue Mar 7, 2022
Open
@ilonatommy
Copy link
Member

@steveisok, any recent thoughts on this? Are there any chances to do it for dotnet 7?

@steveisok
Copy link
Member Author

Now that there is a build with wasm threads enabled, this should be possible. #70461 will make it easier to configure.

@ilonatommy
Copy link
Member

@lewing can you help with assigning?

@bartonjs
Copy link
Member

@steveisok Would "wasm threads" a) mean that we could just use simple sync over async for the crypto API, not have to write our own message pump thing, and b) mean that there are now race conditions possible in the message pump and we have to harden it?

@steveisok
Copy link
Member Author

@steveisok Would "wasm threads" a) mean that we could just use simple sync over async for the crypto API, not have to write our own message pump thing, and b) mean that there are now race conditions possible in the message pump and we have to harden it?

I'm not sure. We're going to have to try and see if sync over async works with the crypto API. The behavior of wasm threads can be a little strange.

@lewing lewing modified the milestones: 7.0.0, 8.0.0 Jul 25, 2022
@pavelsavara pavelsavara assigned radical and pavelsavara and unassigned maraf Aug 8, 2022
@pavelsavara
Copy link
Member

@lewing @eerhardt could this be closed now ?

@eerhardt
Copy link
Member

Given the plan laid out in #40074 (comment) and #73858, I think it should be closed.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 29, 2022
@jeffhandley jeffhandley modified the milestones: 8.0.0, 7.0.0 Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@radical radical

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Security
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests