Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Enable more networking tests #53027

Merged
merged 10 commits into from
Jun 2, 2021

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented May 20, 2021

@ghost
Copy link

ghost commented May 20, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: pavelsavara
Assignees: -
Labels:

area-System.Net

Milestone: -

@pavelsavara pavelsavara added the arch-wasm WebAssembly architecture label May 20, 2021
@ghost
Copy link

ghost commented May 20, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: pavelsavara
Assignees: -
Labels:

arch-wasm, area-System.Net

Milestone: -

@pavelsavara pavelsavara changed the title [wasm] Enable networking tests in outerloop [wasm] Enable more networking tests May 20, 2021
@akoeplinger

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@akoeplinger
Copy link
Member

/azp run runtime-libraries-mono outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-libraries-mono outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-libraries-mono outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-libraries-mono outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-libraries-mono outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-libraries-mono outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-libraries-mono outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-libraries-mono outerloop

@pavelsavara
Copy link
Member Author

pavelsavara commented Jun 2, 2021

@pavelsavara
Copy link
Member Author

pavelsavara commented Jun 2, 2021

  • is this zero?

For System.Net.WebSockets.Client.Tests yes.
For System.Net.Http.Functional.Tests V8 need to skip the same 78 tests as browser, but for different reason. I made that distinction explicit.

I don't believe we need to split this into 2 PRs

@pavelsavara
Copy link
Member Author

/azp run runtime-libraries-mono outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

- fix Quic detection in test
- disable webSocket tests on Mono/Windows
- enable System.Net.Http.Functional.Tests on browser
- disable tests with MaxConnectionsPerServer not supported on Browser
- disable tests with Socket not supported on Browser
- disable tests with AutomaticDecompression not supported on Browser
- disable tests with UseProxy not supported on Browser
- disable tests with Credentials is not supported on Browser
- disable tests with Loopback server
- [ActiveIssue] dotnet#37669 for missing crypto MD5
…Browser to allow System.Net.Http.Functional.Tests pass on V8
- disabled tests with dotnet#53591
- disabled tests with dotnet#53592
@pavelsavara
Copy link
Member Author

/azp run runtime-libraries-mono outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara requested a review from radical June 2, 2021 13:54
Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback. Assuming everything passes, LGTM, thanks 👍

@pavelsavara
Copy link
Member Author

/azp run runtime-libraries-mono outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara merged commit 1e19518 into dotnet:main Jun 2, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 2, 2021
@karelz karelz added this to the 6.0.0 milestone Jul 15, 2021
@pavelsavara pavelsavara deleted the pr_wasm_outerloop branch July 29, 2021 08:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Net
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants