Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows_NT Formatting jobs failing #40034

Closed
jashook opened this issue Jul 28, 2020 · 5 comments
Closed

Windows_NT Formatting jobs failing #40034

jashook opened this issue Jul 28, 2020 · 5 comments
Assignees
Labels
area-Infrastructure-coreclr disabled-test The test is disabled in source code against the issue
Milestone

Comments

@jashook
Copy link
Contributor

jashook commented Jul 28, 2020

Windows formatting failure seems to be a configuration issue while configuring Cmake

/cc @jkoritzinsky @dotnet/jit-contrib


  $<TARGET_PROPERTY:prop> may only be used with binary targets.  It may not
  be used with add_custom_command or add_custom_target.  Specify the target
  to read a property from using the $<TARGET_PROPERTY:tgt,prop> signature
  instead.
CMake Error:
  Error evaluating generator expression:
    $<TARGET_PROPERTY:NAME>
  $<TARGET_PROPERTY:prop> may only be used with binary targets.  It may not
  be used with add_custom_command or add_custom_target.  Specify the target
  to read a property from using the $<TARGET_PROPERTY:tgt,prop> signature
  instead.
CMake Error:
  Error evaluating generator expression:
    $<TARGET_PROPERTY:NAME>
  $<TARGET_PROPERTY:prop> may only be used with binary targets.  It may not
  be used with add_custom_command or add_custom_target.  Specify the target
  to read a property from using the $<TARGET_PROPERTY:tgt,prop> signature
  instead.
CMake Error:
  Error evaluating generator expression:
    $<TARGET_PROPERTY:NAME>
  $<TARGET_PROPERTY:prop> may only be used with binary targets.  It may not
  be used with add_custom_command or add_custom_target.  Specify the target
  to read a property from using the $<TARGET_PROPERTY:tgt,prop> signature
  instead.
CMake Error:
  Error evaluating generator expression:
    $<TARGET_PROPERTY:NAME>
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-coreclr untriaged New issue has not been triaged by the area owner labels Jul 28, 2020
@jashook jashook added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' and removed untriaged New issue has not been triaged by the area owner labels Jul 28, 2020
@jashook
Copy link
Contributor Author

jashook commented Jul 28, 2020

Based on conversations with @safern I will disable the job is it will fail consistently.

@BruceForstall
Copy link
Member

Did the cmake version change on the build machines? What version is it? (btw, we should add cmake --version output in the logfiles). I can't repro this locally with cmake version 3.15.5

@am11
Copy link
Member

am11 commented Jul 28, 2020

Normally on Windows machine, cmake version should be same as

"cmake": "3.14.5",
(this cmake.exe gets downloaded locally from blob storage during the execution of build.cmd)

jashook pushed a commit that referenced this issue Jul 28, 2020
@safern safern added disabled-test The test is disabled in source code against the issue and removed blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' labels Jul 31, 2020
@safern safern added this to the 5.0.0 milestone Jul 31, 2020
@jashook jashook modified the milestones: 5.0.0, 6.0.0 Aug 3, 2020
@sandreenko
Copy link
Contributor

sandreenko commented Aug 7, 2020

@jashook I am not sure why but it looks like the job was not disabled with your change, I see that all outer loop jobs are failing with Windows formatting job.
Update: I have not noticed that the PR was disabling it only in PR testing, not in outer loop.

@sandreenko sandreenko added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' and removed blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' labels Aug 7, 2020
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this issue Aug 10, 2020
BruceForstall added a commit to BruceForstall/runtime that referenced this issue Mar 8, 2021
BruceForstall added a commit that referenced this issue Mar 9, 2021
@BruceForstall
Copy link
Member

Fixed by #49025

@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-coreclr disabled-test The test is disabled in source code against the issue
Projects
None yet
Development

No branches or pull requests

7 participants