Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for System.Diagnostics.Process.Responding #40703

Closed
eiriktsarpalis opened this issue Aug 12, 2020 · 4 comments · Fixed by #46142
Closed

Add tests for System.Diagnostics.Process.Responding #40703

eiriktsarpalis opened this issue Aug 12, 2020 · 4 comments · Fixed by #46142
Assignees
@adamsitnik
Labels
area-System.Diagnostics.Process disabled-test The test is disabled in source code against the issue test-enhancement Improvements of test source code
Milestone
6.0.0

Comments

@eiriktsarpalis
Copy link
Member

#38385 added a test for Process.Responding, which however was disabled since it depends on the current implementation characteristics of Wordpad.

We should replace it with a test that consistently reproduces the behaviour.
@eiriktsarpalis eiriktsarpalis added this to the Future milestone Aug 12, 2020
@ghost
Copy link

ghost commented Aug 12, 2020

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Aug 12, 2020
@eiriktsarpalis eiriktsarpalis added disabled-test The test is disabled in source code against the issue and removed untriaged New issue has not been triaged by the area owner labels Aug 12, 2020
@adamsitnik
Copy link
Member

Wordpad

@eiriktsarpalis did you mean notepad?

runtime/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs

Lines 1598 to 1600 in 021e776

public void MainWindowTitle_GetWithGui_ShouldRefresh_Windows()
{
const string ExePath = "notepad.exe";

@eiriktsarpalis
Copy link
Member Author

No, the PR referenced in #40703 relied on wordpad behaviour to produce a non-responsive process.

@adamsitnik
Copy link
Member

@eiriktsarpalis thanks!

FWIW the commit that removed the test: c4d3ed5

@adamsitnik adamsitnik mentioned this issue Dec 16, 2020
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Dec 16, 2020
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Dec 21, 2020
@adamsitnik adamsitnik modified the milestones: Future, 6.0.0 Dec 21, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adamsitnik adamsitnik

Labels
area-System.Diagnostics.Process disabled-test The test is disabled in source code against the issue test-enhancement Improvements of test source code
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Add test for System.Diagnostics.Process.Responding adamsitnik/runtime
3 participants
@eiriktsarpalis @adamsitnik @Dotnet-GitSync-Bot