Ensure Process.MainWindowTitle and Process.Responding is refreshed #38385

JeroenOortwijn · 2020-06-25T13:35:36Z

PR for issue #36768.

It should fix the issue, but I'm unable to run the tests because opening the solution leads to the following NuGet error:

Error occurred while restoring NuGet packages: Invalid restore input. Duplicate frameworks found: 'net5.0, net5.0, net5.0, net5.0, net5.0, net5.0'. Input files: E:\Repos\JeroenOortwijn\dotnet\runtime\src\libraries\System.Diagnostics.Process\src\System.Diagnostics.Process.csproj.

(Which, I think, is tracked in #34173.)

ghost · 2020-06-25T13:35:42Z

Tagging subscribers to this area: @eiriktsarpalis
Notify danmosemsft if you want to be subscribed.

dnfadmin · 2020-06-25T13:35:50Z

All CLA requirements met.

src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs

stephentoub · 2020-06-25T14:26:54Z

src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs

+                        Thread.Sleep(100);
+                    }
+
+                    Assert.False(process.Responding);


Similar question; why do we expect Responding to be false after a Refresh?

I see this behaviour with the test program that I've written:
https://github.com/JeroenOortwijn/Responding-test

With .Net Framework 4.8, the first Process.Responding call (immediately after Wordpad is started) returns true.
After a couple of seconds, Wordpad is so busy loading the document that the title bar shows "(Not Responding)". At that point, Process.Responding returns false.

Due to issue #36768, Process.Responding keeps returning true on .Net Core 3.1 and .Net 5.

stephentoub · 2020-06-25T14:59:20Z

src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs

+            var dummyFile = new FileStream(dummyFilePath, System.IO.FileMode.Create);
+            _ = dummyFile.Seek(2048L * 1024 * 1024, SeekOrigin.Begin);
+            dummyFile.WriteByte(0);
+            dummyFile.Close();


Woh, this is creating a 2GB temporary file? Even in outerloop that's probably something to be avoided.

You're right, the file is quite big.
But I want to make sure that even on the fastest machine, Wordpad goes into a "not responding" state.
If the file is too small, Wordpad will have loaded the file without getting into that state.

So, some kind of optimum file size has to be found.

If we really need to test that, I suggest the test itself needs to be the thing that causes the non-responsiveness, e.g. the test would RemoteExecutor.Invoke code that would create a window that's not responsive. We shouldn't depend on creating a big enough file that the particular implementation in wordpad causes the UI to hang.

@stephentoub you mean with something like windows forms? I tried the following

static void RunNotRespondingApp() { var form = new System.Windows.Forms.Form(); form.Show(); Thread.Sleep(60_000); } RemoteExecutor.Invoke(RunNotRespondingApp);

but for whatever reason it wasn't enough to simulate not responding state using RemoteExecutor. It does work without issue when I run as a standalone app.

adamsitnik · 2020-07-06T15:49:16Z

@stephentoub could you please respond to @JeroenOortwijn answers to your review comments?

See dotnet#36768.

eiriktsarpalis · 2020-08-11T13:13:02Z

I rebased and ran the tests locally. Can confirm that the changes fix the behaviour (matching it with .NET Framework behaviour). I would recommend merging this PR ahead of the 5.0 deadline, but we could perhaps disable the problematic test (it's not run in CI anyway, and we generally have no test coverage for Process.Responding). cc @adamsitnik @danmosemsft

danmoseley · 2020-08-11T18:29:06Z

I would recommend merging this PR ahead of the 5.0 deadline, but we could perhaps disable the problematic test

Seems reasonable to me.

eiriktsarpalis · 2020-08-12T11:13:18Z

Thanks @JeroenOortwijn for your contribution!

Fixes #36768.

danmoseley · 2020-08-12T12:25:14Z

@dotnet/dnceng @jaredpar timeouts on “ Build OSX x64 release Runtime_Debug” and similar on a lot of.PRs right now having a significant impact. Can you help us understand why?

jaredpar · 2020-08-12T12:43:18Z

@danmosemsft

Looking through the logs it seems like the problem is the C++ build is just taking about 70 minutes to complete on OSX. That is eating up most of the available time for the job.

jakubstilec · 2020-08-12T13:10:42Z

@danmosemsft checking now

jakubstilec · 2020-08-12T13:29:33Z

Job timed out but it wasn't helix machine, but azdo macos machine.

jakubstilec · 2020-08-12T13:33:57Z

I don't see any active issue in azdo. Retried the job and checking.

jakubstilec · 2020-08-12T14:23:34Z

@danmosemsft now macox build job "Build product" has finished in ~56 minutes, previously it timed out in 2 hours. It seems that it was a temporary issue on AzDO side.

jaredpar · 2020-08-12T14:30:52Z

@eiriktsarpalis why are we merging changes when the build legs are timing out?

eiriktsarpalis · 2020-08-12T15:29:05Z

@jaredpar Apologies, I assumed by the conversation that you were discussing infra issues. Do you need me to revert?

FWIW all tests were green on the initial run. The last commit was me deleting a test.

jaredpar · 2020-08-12T15:55:23Z

@jakubstilec latest seems to indicate it's working again so lets keep for now and willmonitor

MattGal · 2020-08-12T17:05:01Z

@danmosemsft

Looking through the logs it seems like the problem is the C++ build is just taking about 70 minutes to complete on OSX. That is eating up most of the available time for the job.

We've moving from MacStadium to GitHub-hosted machines; The new machines have fewer cores. I believe the only option currently is to increase your timeouts but, as usual, I know who you can engage in conversation if you think you can talk them into making beefier mac vms. edit: this is theoretically only true for internal builds; that said they know the new machines are slower in general.

danmoseley · 2020-08-12T18:20:31Z

@MattGal thanks. I think that's for @jaredpar to decide on based on monitoring he mentions..

MattGal · 2020-08-12T19:01:32Z

@MattGal thanks. I think that's for @jaredpar to decide on based on monitoring he mentions..

Yes I did quote reply of him but it looked like I was talking at you, sorry. The key takeaway is they know the new hardware is slower and they're not going back to the old hardware.

danmoseley · 2020-08-12T19:14:38Z

@jaredpar is it simple to increase our timeouts? If so perhaps we should do that pre-emptively, given we expect CI to stay busy for the near future?

Dotnet-GitSync-Bot added the area-System.Diagnostics.Process label Jun 25, 2020

stephentoub reviewed Jun 25, 2020

View reviewed changes

src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs Show resolved Hide resolved

stephentoub reviewed Jun 25, 2020

View reviewed changes

adamsitnik added this to the 5.0.0 milestone Jun 25, 2020

JeroenOortwijn added 6 commits August 10, 2020 13:55

Add test for process.MainWindowTitle refresh bug

ef423c4

See dotnet#36768.

Add test for Process.Responding refresh bug

9a24240

See dotnet#36768.

Ensure Process.MainWindowTitle is refreshed

efc9f5e

See dotnet#36768.

Ensure Process.Responding is refreshed

cbb831b

See dotnet#36768.

Made dummyFilePath const

09ecd10

Fix glaring bugs

18f3c31

eiriktsarpalis force-pushed the Fix-issue-36768-Process.MainWindowTitle-and-Process.Responding-are-not-correctly-refreshed branch from 5eef234 to 18f3c31 Compare August 10, 2020 13:11

eiriktsarpalis mentioned this pull request Aug 12, 2020

Add tests for System.Diagnostics.Process.Responding #40703

Closed

remove Process.Responding test

c4d3ed5

eiriktsarpalis approved these changes Aug 12, 2020

View reviewed changes

eiriktsarpalis merged commit 7d25902 into dotnet:master Aug 12, 2020

JeroenOortwijn deleted the Fix-issue-36768-Process.MainWindowTitle-and-Process.Responding-are-not-correctly-refreshed branch August 12, 2020 18:14

ghost locked as resolved and limited conversation to collaborators Dec 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure Process.MainWindowTitle and Process.Responding is refreshed #38385

Ensure Process.MainWindowTitle and Process.Responding is refreshed #38385

JeroenOortwijn commented Jun 25, 2020

ghost commented Jun 25, 2020

dnfadmin commented Jun 25, 2020 •

edited

Loading

stephentoub Jun 25, 2020

JeroenOortwijn Jun 26, 2020

stephentoub Jun 25, 2020

JeroenOortwijn Jun 26, 2020

stephentoub Jul 10, 2020

eiriktsarpalis Aug 11, 2020

adamsitnik commented Jul 6, 2020

eiriktsarpalis commented Aug 11, 2020 •

edited

Loading

danmoseley commented Aug 11, 2020

eiriktsarpalis commented Aug 12, 2020

danmoseley commented Aug 12, 2020

jaredpar commented Aug 12, 2020

jakubstilec commented Aug 12, 2020

jakubstilec commented Aug 12, 2020

jakubstilec commented Aug 12, 2020

jakubstilec commented Aug 12, 2020

jaredpar commented Aug 12, 2020

eiriktsarpalis commented Aug 12, 2020 •

edited

Loading

jaredpar commented Aug 12, 2020

MattGal commented Aug 12, 2020 •

edited

Loading

danmoseley commented Aug 12, 2020

MattGal commented Aug 12, 2020

danmoseley commented Aug 12, 2020

Ensure Process.MainWindowTitle and Process.Responding is refreshed #38385

Ensure Process.MainWindowTitle and Process.Responding is refreshed #38385

Conversation

JeroenOortwijn commented Jun 25, 2020

ghost commented Jun 25, 2020

dnfadmin commented Jun 25, 2020 • edited Loading

stephentoub Jun 25, 2020

Choose a reason for hiding this comment

JeroenOortwijn Jun 26, 2020

Choose a reason for hiding this comment

stephentoub Jun 25, 2020

Choose a reason for hiding this comment

JeroenOortwijn Jun 26, 2020

Choose a reason for hiding this comment

stephentoub Jul 10, 2020

Choose a reason for hiding this comment

eiriktsarpalis Aug 11, 2020

Choose a reason for hiding this comment

adamsitnik commented Jul 6, 2020

eiriktsarpalis commented Aug 11, 2020 • edited Loading

danmoseley commented Aug 11, 2020

eiriktsarpalis commented Aug 12, 2020

danmoseley commented Aug 12, 2020

jaredpar commented Aug 12, 2020

jakubstilec commented Aug 12, 2020

jakubstilec commented Aug 12, 2020

jakubstilec commented Aug 12, 2020

jakubstilec commented Aug 12, 2020

jaredpar commented Aug 12, 2020

eiriktsarpalis commented Aug 12, 2020 • edited Loading

jaredpar commented Aug 12, 2020

MattGal commented Aug 12, 2020 • edited Loading

danmoseley commented Aug 12, 2020

MattGal commented Aug 12, 2020

danmoseley commented Aug 12, 2020

dnfadmin commented Jun 25, 2020 •

edited

Loading

eiriktsarpalis commented Aug 11, 2020 •

edited

Loading

eiriktsarpalis commented Aug 12, 2020 •

edited

Loading

MattGal commented Aug 12, 2020 •

edited

Loading