Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing command-line-api repo reference in eng/Version.Details.xml #42637

Closed
crummel opened this issue Sep 23, 2020 · 6 comments
Closed

Missing command-line-api repo reference in eng/Version.Details.xml #42637

crummel opened this issue Sep 23, 2020 · 6 comments
Assignees
@EgorBo @AntonLapounov
Labels
area-Tools-ILVerification Issues related to ilverify tool and IL verification in general
Milestone
7.0.0

Comments

@crummel
Copy link
Contributor

crummel commented Sep 23, 2020

Runtime uses the dotnet/command-line-api repo, e.g. here, but this is not included in eng/Version.Details.xml, so Arcade/Maestro package updates and uberclone will not know about the dependency. This should be added at an appropriate version and hash.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Meta untriaged New issue has not been triaged by the area owner labels Sep 23, 2020
@crummel crummel mentioned this issue Sep 23, 2020
Merged
@mangod9 mangod9 removed the untriaged New issue has not been triaged by the area owner label Sep 25, 2020
@mangod9 mangod9 added this to the 6.0.0 milestone Sep 25, 2020
@mangod9
Copy link
Member

mangod9 commented Sep 25, 2020

@AntonLapounov is looking at updating the command-line dependency.

@AntonLapounov AntonLapounov mentioned this issue Oct 4, 2020
Closed
@trylek
Copy link
Member

trylek commented Feb 7, 2021

@AntonLapounov, is this item ready to be closed based on your fix?

@AntonLapounov AntonLapounov mentioned this issue Feb 8, 2021
Closed
@trylek
Copy link
Member

trylek commented Apr 12, 2021

OK, so it looks like this issue now effectively tracks removing the "new slow" System.CommandLine from ILVerify and R2RDump. While I believe that R2RDump is not considered a shipping product now, I'm not sure about ILVerify. If ILVerify is a shipping product, we should migrate it to the same parser as Crossgen2.

@mangod9 mangod9 added area-Tools-ILVerification Issues related to ilverify tool and IL verification in general and removed area-crossgen2-coreclr labels Jul 10, 2021
@mangod9
Copy link
Member

mangod9 commented Jul 10, 2021

Moving to ILVerification area since its now tracking ILVerify's usage of Commandline.

@AntonLapounov
Copy link
Member

The dotnet/source-build#1886 issue that motivated this one has been closed. I don't think it is necessary to do any changes for 6.0.

@JulieLeeMSFT JulieLeeMSFT modified the milestones: 6.0.0, 7.0.0 Jul 20, 2021
@EgorBo
Copy link
Member

EgorBo commented Jun 10, 2022

I assume it was fixed by #66929

@EgorBo EgorBo closed this as completed Jun 10, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EgorBo EgorBo

@AntonLapounov AntonLapounov

Labels
area-Tools-ILVerification Issues related to ilverify tool and IL verification in general
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Add command-line-api repo reference AntonLapounov/runtime
8 participants
@EgorBo @jkotas @crummel @trylek @AntonLapounov @Dotnet-GitSync-Bot @mangod9 @JulieLeeMSFT