Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove System.CommandLine dependency #1886

Closed

Conversation

AntonLapounov
Copy link
Member

System.CommandLine package is no longer needed for Crossgen2.

@AntonLapounov
Copy link
Member Author

Apparently this repo still consumes a release/5.0 build of Crossgen2. The dependency is removed in 6.0 builds.

  <New>
    <Usage Id="Microsoft.CSharp" Version="4.4.1" File="artifacts/src/runtime.cf258a14b70ad9069470a108f13765e0e5988f51/artifacts/obj/coreclr/ILVerify/project.assets.json" />
    <Usage Id="Microsoft.CSharp" Version="4.4.1" File="artifacts/src/runtime.cf258a14b70ad9069470a108f13765e0e5988f51/artifacts/obj/coreclr/crossgen2/project.assets.json" />
    <Usage Id="System.CommandLine" Version="2.0.0-beta1.20253.1" File="artifacts/src/runtime.cf258a14b70ad9069470a108f13765e0e5988f51/artifacts/obj/coreclr/ILVerify/project.assets.json" IsDirectDependency="true" />
    <Usage Id="System.CommandLine" Version="2.0.0-beta1.20253.1" File="artifacts/src/runtime.cf258a14b70ad9069470a108f13765e0e5988f51/artifacts/obj/coreclr/crossgen2/project.assets.json" IsDirectDependency="true" />
  </New>

@AntonLapounov AntonLapounov marked this pull request as draft November 15, 2020 00:07
@crummel
Copy link
Contributor

crummel commented Feb 18, 2021

@crummel to follow up

@AntonLapounov
Copy link
Member Author

We are discussing whether want to use System.CommmandLine in other Runtime packages. If yes, we will add a reference there.

@omajid
Copy link
Member

omajid commented Feb 19, 2021

dotnet/core#5853 (comment) says that the SDK uses System.CommandLine. If that's true, I dont think we can drop it from source-build.

@AntonLapounov
Copy link
Member Author

@omajid My understanding is that System.CommandLine should be listed in SDK's eng/Version.Details.xml then.

@crummel crummel self-assigned this Mar 4, 2021
@crummel
Copy link
Contributor

crummel commented Mar 4, 2021

Triage: @crummel to follow up on what actually needs this and file upstream PR to fix Version.Details.xml.

@dseefeld
Copy link
Contributor

This looks like it includes updates for 6.0. We should pick those changes up with ArPow. This should not be needed in source-build master.

Thanks for bringing this to our attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants