Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command-line-api repo reference #43020

Conversation

AntonLapounov
Copy link
Member

Fixes #42637.

@jkotas
Copy link
Member

jkotas commented Oct 5, 2020

System.CommandLine package has poor performance that we need to do something about. Also, I suspect that System.CommandLine will require more work in https://github.com/dotnet/source-build .

Should we rather switch back to the light-weight command line parser we used to have? (You can take it from https://github.com/dotnet/runtimelab/tree/feature/NativeAOT/src/coreclr/src/tools/System.CommandLine/System/CommandLine).

@ViktorHofer
Copy link
Member

cc @trylek who I believe switched to it (50c3665).

@crummel
Copy link
Contributor

crummel commented Oct 5, 2020

@jkotas We actually already added this as part of our prebuilt removal - I logged this issue because System.CommandLine was not actually included in the tree anywhere and we had to add it to our Version.Details.xml. That being said, source-build will never be upset about removing a repo dependency if that works better for you.

@davidwrighton
Copy link
Member

@AntonLapounov do you intend to merge this PR, or are we just going to remove all use of this command line parser?

@AntonLapounov
Copy link
Member Author

AntonLapounov commented Oct 30, 2020

While I have removed its usage from Crossgen2, it is still used in 4 projects: https://github.com/dotnet/runtime/search?q=SystemCommandLineVersion. Do we have to remove it from everywhere in order to not merge this PR, or just from the components that we ship?

@AntonLapounov
Copy link
Member Author

According to @crummel, we only need to remove this dependency from shipping components and anything that is required to build those shipping components. I am abandoning this PR.

@AntonLapounov AntonLapounov deleted the AddCommandLineApiRepoReference branch November 5, 2020 22:24
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing command-line-api repo reference in eng/Version.Details.xml
6 participants