Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure: System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_IdleConnectionTimeoutExpired_ConnectionRemovedAndNewCreated #43877

Closed
v-haren opened this issue Oct 27, 2020 · 14 comments · Fixed by #55820
Closed

Test failure: System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_IdleConnectionTimeoutExpired_ConnectionRemovedAndNewCreated #43877

v-haren opened this issue Oct 27, 2020 · 14 comments · Fixed by #55820
Labels
area-System.Net.Http disabled-test The test is disabled in source code against the issue test-run-core Test failures in .NET Core test runs
Milestone
6.0.0

Comments

@v-haren
Copy link

v-haren commented Oct 27, 2020

failed in job: runtime-libraries-coreclr outerloop 20201026.3

net6.0-Linux-Release-x64-CoreCLR_release-(Ubuntu.1910.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-19.10-helix-amd64-cfcfd50-20191030180623

Error message

Assert.Equal() Failure
Expected: 2
Actual:   1


Stack trace
   at System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_IdleConnectionTimeoutExpired_ConnectionRemovedAndNewCreated() in /_/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs:line 2217
--- End of stack trace from previous location ---
@ghost
Copy link

ghost commented Oct 27, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Oct 27, 2020
@v-haren
Copy link
Author

v-haren commented Nov 26, 2020

failed again in job: runtime-libraries-coreclr outerloop 20201125.1

failed test: System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_IdleConnectionTimeoutExpired_ConnectionRemovedAndNewCreated

net6.0-Linux-Release-x64-CoreCLR_release-Debian.9.Amd64.Open

Error message

Assert.Equal() Failure
Expected: 2
Actual:   1


Stack trace
   at System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_IdleConnectionTimeoutExpired_ConnectionRemovedAndNewCreated() in /_/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs:line 2217
--- End of stack trace from previous location ---

@karelz karelz added this to the 6.0.0 milestone Dec 1, 2020
@karelz karelz added test-run-core Test failures in .NET Core test runs and removed untriaged New issue has not been triaged by the area owner labels Dec 1, 2020
@ManickaP
Copy link
Member

We might consider disable this one as well. It steadily fails every other day:

Queued Duration Message Exception QueueName Type1
2020-12-10T12:19:52.909Z 60.016 Assert.Equal() Failure\nExpected: 2\nActual: 1 ubuntu.1604.amd64.open.rt test/functional/cli/outerloop/
2020-12-08T17:03:04.548Z 60.023 Assert.Equal() Failure\nExpected: 2\nActual: 1 ubuntu.1604.amd64.open.rt test/functional/cli/outerloop/
2020-12-08T11:59:38.885Z 60.02 Assert.Equal() Failure\nExpected: 2\nActual: 1 ubuntu.1604.amd64.open.rt test/functional/cli/outerloop/
2020-12-05T11:54:02.543Z 60.023 Assert.Equal() Failure\nExpected: 2\nActual: 1 ubuntu.1604.amd64.open.rt test/functional/cli/outerloop/
2020-12-03T12:12:24.309Z 60.017 Assert.Equal() Failure\nExpected: 2\nActual: 1 ubuntu.1604.amd64.open.rt test/functional/cli/outerloop/
2020-12-01T01:41:25.196Z 60.0210146 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException debian.9.amd64.open.rt test/functional/cli/innerloop/
2020-11-30T11:46:09.738Z 60.0158047 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1604.amd64.open.rt test/functional/cli/outerloop/
2020-11-29T12:26:12.234Z 60.0528061 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1604.amd64.open.rt test/functional/cli/outerloop/
2020-11-26T12:01:31.352Z 60.0140252 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1604.amd64.open.rt test/functional/cli/outerloop/
2020-11-25T12:02:05.892Z 60.0226894 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException debian.9.amd64.open.rt test/functional/cli/outerloop/
2020-11-24T18:19:52.047Z 60.0168769 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException sles.12.amd64.open.rt test/functional/cli/innerloop/
2020-11-23T22:08:14.172Z 60.0189548 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1604.amd64.open.rt test/functional/cli/outerloop/
2020-11-23T12:13:42.103Z 60.0146112 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1604.amd64.open.rt test/functional/cli/outerloop/
2020-11-23T01:39:30.498Z 60.0221159 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1604.amd64.open.rt test/functional/cli/innerloop/
2020-11-23T00:35:53.544Z 60.0261906 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1604.amd64.open.rt test/functional/cli/outerloop/
2020-11-22T03:09:36.421Z 60.021282 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1604.amd64.open.rt test/functional/cli/outerloop/
2020-11-20T12:17:57.454Z 60.031967 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1604.amd64.open.rt test/functional/cli/outerloop/
2020-11-20T06:17:08.966Z 60.0173632 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException sles.15.amd64.open.rt test/functional/cli/innerloop/
2020-11-17T12:11:41.979Z 60.0432125 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1804.amd64.open.rt test/functional/cli/outerloop/
2020-11-16T12:08:56.774Z 60.0305342 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException sles.12.amd64.open.rt test/functional/cli/outerloop/
2020-11-14T11:58:40.765Z 60.0262203 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1604.amd64.open.rt test/functional/cli/outerloop/
2020-11-14T11:58:34.95Z 60.0315422 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException debian.9.amd64.open.rt test/functional/cli/outerloop/
2020-11-13T22:14:14.061Z 60.0179671 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1604.amd64.open.rt test/functional/cli/innerloop/
2020-11-13T16:14:04.683Z 60.0196313 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException sles.15.amd64.open.rt test/functional/cli/innerloop/
2020-11-13T15:54:22.547Z 60.0180469 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1604.amd64.open.rt test/functional/cli/innerloop/
2020-11-12T12:32:52.653Z 60.0320077 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1604.amd64.open.rt test/functional/cli/outerloop/
2020-11-08T11:59:39.336Z 60.0314569 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1604.amd64.open test/functional/cli/outerloop/
2020-11-05T12:02:47.988Z 60.1641286 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1804.armarch.open test/functional/cli/outerloop/
2020-11-03T12:07:13.525Z 60.0227342 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1604.amd64.open test/functional/cli/outerloop/
2020-11-01T15:54:09.508Z 60.0200438 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1604.amd64.open test/functional/cli/outerloop/
2020-10-30T12:00:37.494Z 60.0137323 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1604.amd64.open test/functional/cli/outerloop/
2020-10-26T12:11:21.795Z 60.014107 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1604.amd64.open test/functional/cli/outerloop/
2020-10-21T12:01:02.553Z 60.0222572 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1604.amd64.open test/functional/cli/outerloop/
2020-10-20T01:44:44.887Z 60.0365392 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1604.amd64.open test/functional/cli/outerloop/
2020-10-20T01:44:42.695Z 60.0307921 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1604.amd64.open test/functional/cli/outerloop/
2020-10-17T08:40:47.397Z 60.0329814 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException sles.12.amd64.open test/functional/cli/innerloop/
2020-10-14T13:34:53.76Z 60.0383223 Assert.Equal() Failure\nExpected: 2\nActual: 1 Xunit.Sdk.EqualException ubuntu.1804.amd64.open test/functional/cli/innerloop/

@v-haren
Copy link
Author

v-haren commented Jan 8, 2021

failed again in job: runtime-libraries-coreclr outerloop 20210107.2

failed test: System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_IdleConnectionTimeoutExpired_ConnectionRemovedAndNewCreated

net6.0-Linux-Release-x64-CoreCLR_release-(Fedora.30.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-30-helix-20200512010621-4f8cef7

Error message

Assert.Equal() Failure
Expected: 2
Actual:   1


Stack trace
   at System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_IdleConnectionTimeoutExpired_ConnectionRemovedAndNewCreated() in /_/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs:line 2218
--- End of stack trace from previous location ---

@VincentBu
Copy link
Contributor

Failed again in run : runtime-libraries-coreclr outerloop 20210128.2

Failed test : System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_IdleConnectionTimeoutExpired_ConnectionRemovedAndNewCreated

net6.0-Linux-Release-x64-CoreCLR_release-(Fedora.30.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-30-helix-20200512010621-4f8cef7

Error message:

Assert.Equal() Failure
Expected: 2
Actual:   1


Stack trace
   at System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_IdleConnectionTimeoutExpired_ConnectionRemovedAndNewCreated() in /_/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs:line 2218
--- End of stack trace from previous location ---

@antonfirsov antonfirsov mentioned this issue Feb 1, 2021
Merged
@antonfirsov antonfirsov mentioned this issue Feb 9, 2021
Merged
@VincentBu
Copy link
Contributor

Failed again in runtime-libraries-coreclr outerloop 20210407.3

Failed test:

net6.0-Linux-Release-x64-CoreCLR_release-(Alpine.312.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.12-helix-20200601195603-e06dc59
 -System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_IdleConnectionTimeoutExpired_ConnectionRemovedAndNewCreated

Error message:

Assert.Equal() Failure
Expected: 2
Actual:   1


Stack trace
   at System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_IdleConnectionTimeoutExpired_ConnectionRemovedAndNewCreated() in /_/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs:line 2239
--- End of stack trace from previous location ---

@VincentBu
Copy link
Contributor

Failed again in runtime-libraries-coreclr outerloop 20210427.4

Failed test:

net6.0-Linux-Release-x64-CoreCLR_release-(Centos.8.Amd64.Open)Ubuntu.1604.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:centos-8-helix-20201229003624-c1bf759
 -System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_IdleConnectionTimeoutExpired_ConnectionRemovedAndNewCreated

Error message:

Assert.Equal() Failure
Expected: 2
Actual:   1


Stack trace
   at System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_IdleConnectionTimeoutExpired_ConnectionRemovedAndNewCreated() in /_/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs:line 2239
--- End of stack trace from previous location ---

@antonfirsov antonfirsov mentioned this issue May 5, 2021
Merged
@karelz
Copy link
Member

karelz commented May 10, 2021

Failures during 3/11-5/10 (incl. PRs): 34 failures ... we absolutely need to disable this test.

@karelz karelz mentioned this issue May 10, 2021
Merged
@karelz
Copy link
Member

karelz commented May 10, 2021

From @ManickaP: With this test disabled, it looks like we're down to a single HTTP2 multiple connections test.

We should not punt this disabled test to Future without increasing test coverage of the space.

karelz added a commit that referenced this issue May 11, 2021
@karelz
Disable Http2_MultipleConnectionsEnabled_IdleConnectionTimeoutExpired…
b0c7f04 
…_ConnectionRemovedAndNewCreated (#52555)

Disable test System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_IdleConnectionTimeoutExpired_ConnectionRemovedAndNewCreated

Disabled test tracked by #43877
@karelz karelz added the disabled-test The test is disabled in source code against the issue label May 11, 2021
@karelz
Copy link
Member

karelz commented May 11, 2021

Test disabled in #52555

@alnikola alnikola assigned alnikola and unassigned alnikola Jun 24, 2021
@alnikola alnikola mentioned this issue Jul 1, 2021
Closed
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 1, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 13, 2021
@alnikola
Copy link
Contributor

This failure is probably caused by the bug in Http2Connection.GetIdleTicks method.

@karelz
Copy link
Member

karelz commented Jul 16, 2021

@alnikola which bug do you have on mind?

@alnikola alnikola mentioned this issue Jul 16, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 16, 2021
@alnikola
Copy link
Contributor

The incorrect operand order.
Now (broken): _idleSinceTickCount - nowTicks
Fixed: nowTicks - _idleSinceTickCount

@karelz
Copy link
Member

karelz commented Jul 16, 2021

Ah, nice catch!

alnikola added a commit that referenced this issue Jul 16, 2021
@alnikola
Fix Http2Connection.GetIdleTicks (#55820)
04a8f5e 
There is currently a wrong operand order in the subtraction.

Fixes #43877
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 16, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Net.Http disabled-test The test is disabled in source code against the issue test-run-core Test failures in .NET Core test runs
Projects
None yet
Milestone
6.0.0
6 participants
@karelz @ManickaP @v-haren @VincentBu @Dotnet-GitSync-Bot @alnikola