Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Http2_MultipleConnectionsEnabled_IdleConnectionTimeoutExpired_ConnectionRemovedAndNewCreated #52555

Merged
merged 2 commits into from
May 11, 2021

Conversation

karelz
Copy link
Member

@karelz karelz commented May 10, 2021

DisdabledDisable test System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_IdleConnectionTimeoutExpired_ConnectionRemovedAndNewCreated

Disabled test tracked by #43877

@ghost
Copy link

ghost commented May 10, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Disable test System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_IdleConnectionTimeoutExpired_ConnectionRemovedAndNewCreated

Tracked by #43877

Author: karelz
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this test disabled, it looks like we're down to a single HTTP2 multiple connections test.
Are we OK with such a small coverage?

@karelz
Copy link
Member Author

karelz commented May 10, 2021

Good point about low coverage, we should prioritize it. I didn't push the issue out of 6.0 BTW.

@karelz karelz merged commit b0c7f04 into dotnet:main May 11, 2021
@karelz karelz deleted the DisableHttp2Test branch May 14, 2021 11:16
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants