Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gaps in kestrel version of networking test echo server (as compared to obsolete CoreFxNetCloudService) #52693

Open
pavelsavara opened this issue May 13, 2021 · 3 comments
Open

Gaps in kestrel version of networking test echo server (as compared to obsolete CoreFxNetCloudService) #52693

pavelsavara opened this issue May 13, 2021 · 3 comments
Labels
area-System.Net.Http help wanted [up-for-grabs] Good issue for external contributors test-enhancement Improvements of test source code
Milestone
Future

Comments

@pavelsavara
Copy link
Member

pavelsavara commented May 13, 2021 •
edited
Loading

In #52642 as part of #42852 we are bringing kestrel version of the obsolete CoreFxNetCloudService echo test server.

The proposed implementation is missing:

  • Any deployment logic to be able to host it in Azure
  • Any test certificates, which the unit tests may expect
  • ClientCertificate capturing in NetCoreServer\Helpers\RequestInformation.cs and necessary setup of kestrel to receive it.
  • delete the obsolete CoreFxNetCloudService from runtime repo
@pavelsavara pavelsavara added area-System.Net.Http test-enhancement Improvements of test source code labels May 13, 2021
@ghost
Copy link

ghost commented May 13, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

As part of #42852 we are bringing kestrel version of the CoreFxNetCloudService echo test server. The proposed implementation is missing:

  • Any deployment logic to be able to host it in Azure- ClientCertificate capturing in
  • Any test certificates, which the unit tests may expect
  • NetCoreServer\Helpers\RequestInformation.cs and necessary setup of kestrel to receive it. See this conversation
Author: pavelsavara
Assignees: -
Labels:

area-System.Net.Http, test enhancement
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label May 13, 2021
This was referenced May 13, 2021
Merged
Closed
@pavelsavara pavelsavara changed the title Improve kestrel version of networking test echo server (previously CoreFxNetCloudService) Gaps in kestrel version of networking test echo server (as compared to obsolete CoreFxNetCloudService) May 13, 2021
@karelz
Copy link
Member

karelz commented May 25, 2021

Triage: We should delete the old code as it is unused.
We can ignore the rest, until it is needed.

@karelz karelz added this to the Future milestone May 25, 2021
@karelz karelz added help wanted [up-for-grabs] Good issue for external contributors and removed untriaged New issue has not been triaged by the area owner labels May 25, 2021
@pedrobsaila pedrobsaila mentioned this issue Nov 1, 2021
Closed
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Nov 1, 2021
@pedrobsaila
Copy link
Contributor

pedrobsaila commented Nov 1, 2021 •
edited
Loading

Hi
I made a PR #61058 for this issue

@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-System.Net.Http help wanted [up-for-grabs] Good issue for external contributors test-enhancement Improvements of test source code
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Delete the obsolete CoreFxNetCloudService pedrobsaila/runtime
3 participants
@pavelsavara @karelz @pedrobsaila