Refresh network tests server code to Kestrel #52642
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsPreparation for hosting this server also in xharness process in order to improve #42852
|
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsPreparation for hosting this server also in xharness process in order to improve #42852
|
pavelsavara
changed the title
src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Helpers/RequestInformation.cs
Outdated
Show resolved
Hide resolved
pavelsavara
force-pushed
the
pr_move_network_test_server
branch
from
9365dea
to
0ddf37e
Compare
| using Microsoft.AspNetCore.Http; | ||
| using Microsoft.AspNetCore.Http.Features; | ||
|
|
||
| namespace NetCoreServer |
There was a problem hiding this comment.
I'm not sure if this is best name since .NET Core become just .NET in 5.0.
Since this is purely related to testing perhaps the name can reflect that.
|
|
||
| if (context.Request.QueryString.HasValue && context.Request.QueryString.Value.Contains("delay10sec")) | ||
| { | ||
| Thread.Sleep(10000); |
There was a problem hiding this comment.
await Task.Delay() ? since this is async function? I assume this is copy of original, code right?
| } | ||
| catch (Exception) | ||
| { | ||
| // We might want to log these exceptions. But for now we ignore them. |
There was a problem hiding this comment.
That may be hard for Azure service but perhaps simple print would be still beneficial. Unless there is easy way how to emit Kestrel error message.
ghost
locked as resolved and limited conversation to collaborators
This brings davidsh's
corefx-net-endpointinto runtime repository.It's almost 1:1 copy, with minor changes
This new server doesn't cover full scope of the obsolete server. I created #52693 to describe the gaps I know about.
This makes it possible to hosts this server as Kestrel middleware also inside of xharness process in order to improve #42852