Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete the obsolete CoreFxNetCloudService #61058

Closed
wants to merge 3 commits into from
Closed

Delete the obsolete CoreFxNetCloudService #61058

wants to merge 3 commits into from

Conversation

pedrobsaila
Copy link
Contributor

Fixes #52693

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 1, 2021
@ghost
Copy link

ghost commented Nov 1, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #52693

Author: pedrobsaila
Assignees: -
Labels:

area-System.Net.Http
Milestone: -

@pedrobsaila pedrobsaila mentioned this pull request Nov 1, 2021
Open
@pavelsavara
Copy link
Member

This is the old one https://github.com/dotnet/runtime/tree/f309b53d4e435dbe4a7945676d167ef910959403/src/libraries/Common/tests/System/Net/Prerequisites/Servers/CoreFxNetCloudService

The one this PR deleted is in use.

I also wonder if that old one could be really deleted, because that's what's deployed to Azure for coreCLR outerloop tests. This PR doesn't address deployment and other concerns raised in the linked issues.

@pavelsavara pavelsavara added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 1, 2021
@pedrobsaila
Copy link
Contributor Author

@pavelsavara my bad sorry, I mistook the class.
I didn't address the other concerns because of the follwoing comment in the issue :

Triage: We should delete the old code as it is unused.
We can ignore the rest, until it is needed.

@pavelsavara
Copy link
Member

@karelz is the CoreFxNetCloudService really unused at the moment ? Or is that what lives in Azure right now ?

@pedrobsaila No worries, I will close this one and you could try the other one, based on Karel's answer.

@pavelsavara pavelsavara closed this Nov 1, 2021
@pedrobsaila pedrobsaila deleted the 52693 branch November 1, 2021 19:41
@karelz karelz added this to the 7.0.0 milestone Nov 4, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pavelsavara pavelsavara pavelsavara left review comments

Assignees
No one assigned
Labels
area-System.Net.Http community-contribution Indicates that the PR has been added by a community member NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Gaps in kestrel version of networking test echo server (as compared to obsolete CoreFxNetCloudService)
3 participants
@pedrobsaila @pavelsavara @karelz