Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the DllImportGenerator be packable or not? #65495

Closed
ViktorHofer opened this issue Feb 17, 2022 · 4 comments · Fixed by #65795
Closed

Should the DllImportGenerator be packable or not? #65495

ViktorHofer opened this issue Feb 17, 2022 · 4 comments · Fixed by #65795
Labels
area-Infrastructure-libraries design-discussion Ongoing discussion about design without consensus untriaged New issue has not been triaged by the area owner
Milestone
7.0.0

Comments

@ViktorHofer
Copy link
Member

The DllImportGenerator.csproj sets IsPackable to true but the outer Directory.Build.props sets it to false.

Because of that, packaging is currently disabled. Should it be enabled or not? @jkoritzinsky @MichalStrehovsky
@ViktorHofer ViktorHofer added design-discussion Ongoing discussion about design without consensus area-Infrastructure-libraries labels Feb 17, 2022
@ViktorHofer ViktorHofer added this to the 7.0.0 milestone Feb 17, 2022
@ghost
Copy link

ghost commented Feb 17, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

The DllImportGenerator.csproj sets IsPackable to true but the outer Directory.Build.props sets it to false.

Because of that, packaging is currently disabled. Should it be enabled or not? @jkoritzinsky @MichalStrehovsky

Author: ViktorHofer
Assignees: -
Labels:

Design Discussion, area-Infrastructure-libraries
Milestone: 7.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 17, 2022
@ViktorHofer
Copy link
Member Author

@jkoritzinsky @MichalStrehovsky do you know?

@MichalStrehovsky
Copy link
Member

MichalStrehovsky commented Feb 23, 2022 •
edited
Loading

@jkoritzinsky @MichalStrehovsky do you know?

Cc @dotnet/interop-contrib. I don't know much about DllImportGenerator. I made an unrelated fix in the above mentioned Directory.Build.props because it was causing test breaks but that's the extent of my involvement.

@AaronRobinsonMSFT
Copy link
Member

@ViktorHofer We can remove this for now. We don't need it packable at present. There is a desire to make it packable in the future but we'll do that work when it becomes relevant.

ViktorHofer added a commit that referenced this issue Feb 23, 2022
@ViktorHofer
Disable packaging for DllImportGenerator for now
007f442 
For reasoning see #65495 (comment).
@ViktorHofer ViktorHofer mentioned this issue Feb 23, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 23, 2022
ViktorHofer added a commit that referenced this issue Feb 23, 2022
@ViktorHofer
Disable packaging for DllImportGenerator for now (#65795)
ef231a1 
* Disable packaging for DllImportGenerator for now

For reasoning see #65495 (comment).
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 23, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Infrastructure-libraries design-discussion Ongoing discussion about design without consensus untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Disable packaging for DllImportGenerator for now dotnet/runtime
3 participants
@ViktorHofer @MichalStrehovsky @AaronRobinsonMSFT