Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPMI CI runs need to surface context misses #70350

Closed
jakobbotsch opened this issue Jun 7, 2022 · 4 comments · Fixed by #74584
Closed

SPMI CI runs need to surface context misses #70350

jakobbotsch opened this issue Jun 7, 2022 · 4 comments · Fixed by #74584
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone

Comments

@jakobbotsch
Copy link
Member

If there are a significant number of misses in SPMI runs then the results we show on the "Extensions" page are very misleading, both for the ASM diffs and TP impact. We need to surface the misses so that we can more easily evaluate whether a normal jit-diff run is needed.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jun 7, 2022
@jakobbotsch jakobbotsch added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed untriaged New issue has not been triaged by the area owner labels Jun 7, 2022
@ghost
Copy link

ghost commented Jun 7, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

If there are a significant number of misses in SPMI runs then the results we show on the "Extensions" page are very misleading, both for the ASM diffs and TP impact. We need to surface the misses so that we can more easily evaluate whether a normal jit-diff run is needed.

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr, untriaged

Milestone: -

@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib

@BruceForstall
Copy link
Member

Related, there's a request to surface asserts on the Extensions page as well: #61483

@JulieLeeMSFT JulieLeeMSFT added this to the 8.0.0 milestone Jun 8, 2022
@jakobbotsch jakobbotsch self-assigned this Aug 25, 2022
jakobbotsch added a commit to jakobbotsch/runtime that referenced this issue Aug 25, 2022
* Report the total number of contexts, minopts contexts and fullopts
  contexted processed
* Report number of successful and missing contexts
* Report asmdiffs and tpdiffs for minopts/fullopts separately

Fixes dotnet#70350
Contributes to dotnet#73506
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 25, 2022
jakobbotsch added a commit that referenced this issue Sep 19, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Report the total number of contexts, minopts contexts and fullopts
  contexted processed
* Report number of successful and missing contexts
* Report asmdiffs and tpdiffs for minopts/fullopts separately

Fixes #70350
Contributes to #73506
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Sep 19, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants