Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SuperPMI diffs output: add more metrics #73506

Open
BruceForstall opened this issue Aug 5, 2022 · 2 comments
Open

SuperPMI diffs output: add more metrics #73506

BruceForstall opened this issue Aug 5, 2022 · 2 comments
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI Priority:3 Work that is nice to have
Milestone
Future

Comments

@BruceForstall
Copy link
Member

BruceForstall commented Aug 5, 2022 •
edited
Loading

The superpmi-diffs pipeline displays asm diffs summaries as well as throughput diffs.

What else could be shown? E.g.,

  • memory usage diffs (e.g., from stats collected in the MEASURE_MEM_ALLOC #define)
  • other metrics diffs from our possible new generalized metrics framework

Related: #73505

@dotnet/jit-contrib

category:eng-sys
theme:super-pmi
skill-level:beginner
cost:small
impact:small
@BruceForstall BruceForstall added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 5, 2022
@BruceForstall BruceForstall added this to the 8.0.0 milestone Aug 5, 2022
@ghost
Copy link

ghost commented Aug 5, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

The superpmi-diffs pipeline displays asm diffs summaries as well as throughput diffs.

What else could be shown? E.g.,

  • memory usage diffs
  • other metrics diffs from our possible new generalized metrics framework

Related: #73505

@dotnet/jit-contrib

Author: BruceForstall
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: 8.0.0

@jakobbotsch
Copy link
Member

#70350 is tangentially related

jakobbotsch added a commit to jakobbotsch/runtime that referenced this issue Aug 25, 2022
@jakobbotsch
JIT: Enhance metrics reported by superpmi diffs
ba7bd0c 
* Report the total number of contexts, minopts contexts and fullopts
  contexted processed
* Report number of successful and missing contexts
* Report asmdiffs and tpdiffs for minopts/fullopts separately

Fixes dotnet#70350
Contributes to dotnet#73506
@jakobbotsch jakobbotsch mentioned this issue Aug 25, 2022
Merged
jakobbotsch added a commit that referenced this issue Sep 19, 2022
@jakobbotsch
JIT: Enhance metrics reported by superpmi diffs (#74584)
c3d09aa 
* Report the total number of contexts, minopts contexts and fullopts
  contexted processed
* Report number of successful and missing contexts
* Report asmdiffs and tpdiffs for minopts/fullopts separately

Fixes #70350
Contributes to #73506
@JulieLeeMSFT JulieLeeMSFT modified the milestones: 8.0.0, 9.0.0 Aug 7, 2023
@JulieLeeMSFT JulieLeeMSFT added the Priority:3 Work that is nice to have label Apr 9, 2024
@AndyAyersMS AndyAyersMS modified the milestones: 9.0.0, Future Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI Priority:3 Work that is nice to have
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@jakobbotsch @AndyAyersMS @BruceForstall @JulieLeeMSFT