Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Reconsider setting GTF_GLOB_REF in gtNewFieldRef #74563

Closed
jakobbotsch opened this issue Aug 25, 2022 · 1 comment · Fixed by #84349
Closed

JIT: Reconsider setting GTF_GLOB_REF in gtNewFieldRef #74563

jakobbotsch opened this issue Aug 25, 2022 · 1 comment · Fixed by #84349
Assignees
@jakobbotsch
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
8.0.0

Comments

@jakobbotsch
Copy link
Member

jakobbotsch commented Aug 25, 2022 •
edited by BruceForstall
Loading

#72714 (comment)

Also allow the CEE_DUP cloning that is being disallowed in that PR.

category:implementation
theme:ir
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 25, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Aug 25, 2022
@jakobbotsch jakobbotsch added this to the 8.0.0 milestone Aug 25, 2022
@ghost
Copy link

ghost commented Aug 25, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

#72714 (comment)

Also allow the CEE_DUP cloning that is being disallowed in that PR.

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@jakobbotsch jakobbotsch self-assigned this Aug 25, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Aug 25, 2022
@jakobbotsch jakobbotsch mentioned this issue Aug 25, 2022
Merged
@jakobbotsch jakobbotsch mentioned this issue Mar 30, 2023
Merged
jakobbotsch added a commit to jakobbotsch/runtime that referenced this issue Apr 5, 2023
@jakobbotsch
JIT: Avoid unnecessary GTF_GLOB_REFs
4ae47a2 
* Avoid setting GTF_GLOB_REF on GT_FIELD_ADDR nodes
* Avoid setting GTF_GLOB_REF on GT_FIELD nodes off of implicit byrefs.
  This is ok now since implicit byref morphing indiscriminately sets
  GTF_GLOB_REF for these.

These changes are necessary to avoid address exposure in the two user
benchmarks in dotnet#83388.

Fix dotnet#74563
@jakobbotsch jakobbotsch mentioned this issue Apr 5, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 5, 2023
jakobbotsch added a commit that referenced this issue Apr 7, 2023
@jakobbotsch
JIT: Avoid unnecessary GTF_GLOB_REFs (#84349)
15c7022 
* Avoid setting GTF_GLOB_REF on GT_FIELD_ADDR nodes
* Avoid setting GTF_GLOB_REF on GT_FIELD nodes off of implicit byrefs.
  This is ok now since implicit byref morphing indiscriminately sets
  GTF_GLOB_REF for these.
* Manually clone a "pointer to span" in span intrinsic expansion when it points to a local. Unfortunately this does not fall out from the above since gtClone does not handle FIELD_ADDR, and making it handle this needs some more work.

These changes are necessary to avoid address exposure in the two user
benchmarks in #83388.

Fix #74563
Fix #856
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 7, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

JIT: Avoid unnecessary GTF_GLOB_REFs jakobbotsch/runtime
1 participant
@jakobbotsch