Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NativeAOT doesn't produce IL2109 - RUC on base type #81158

Closed
vitek-karas opened this issue Jan 25, 2023 · 1 comment · Fixed by #83417
Closed

NativeAOT doesn't produce IL2109 - RUC on base type #81158

vitek-karas opened this issue Jan 25, 2023 · 1 comment · Fixed by #83417
Labels
area-NativeAOT-coreclr

Comments

@vitek-karas
Copy link
Member

Along with fixing this should come porting of the linker tests for this to NativeAOT
@ghost
Copy link

ghost commented Jan 25, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Along with fixing this should come porting of the linker tests for this to NativeAOT

Author: vitek-karas
Assignees: -
Labels:

area-NativeAOT-coreclr
Milestone: -

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jan 25, 2023
@vitek-karas vitek-karas mentioned this issue Jan 25, 2023
Closed
6 tasks
@agocke agocke added this to AppModel Mar 6, 2023
@vitek-karas vitek-karas mentioned this issue Mar 14, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 14, 2023
vitek-karas added a commit that referenced this issue Mar 16, 2023
@vitek-karas
Implements Requires*Attribute on class behavior for NativeAOT (#83417)
5bdc36e 
Implements most of the missing pieces to get Requires on class working correctly in NativeAOT.

Major changes:
* Detect Requires mismatch between derived and base class
* Warn on field access if the owning class has Requires
* Changes to reflection marking to warn on more cases (instance methods on Requires classes for example)

Supportive changes:
* The helpers to detect Requires attributes now return the found attribute view out parameter

Fixes #81158

Still two missing pieces - tracked by #82447:
* Requires on attributes - NativeAOT doesn't handle this at all yet, part of it is Requires on the attribute class
* Avoid warning when DAM marking an override method which has Requires (or its class has) - this avoids lot of noise, NativeAOT currently generates these warnings in full
@ghost ghost removed in-pr There is an active PR which will close this issue when it is merged untriaged New issue has not been triaged by the area owner labels Mar 16, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-NativeAOT-coreclr
Projects
AppModel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implements Requires*Attribute on class behavior for NativeAOT vitek-karas/runtime
1 participant
@vitek-karas