Consider adding BBJ_EHFAULTRET #84307
Assignees
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Comments
BruceForstall
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsThe IL So, consider adding a
|
BruceForstall
added a commit
to BruceForstall/runtime
that referenced
this issue
Apr 7, 2023
The IL `endfinally` and `endfault` instructions are aliases, imported in the JIT IR as `BBJ_EHFINALLYRET`. Introduce `BBJ_EHFAULTRET` for cases within `fault` clauses. This simplifies some code, and makes it more clear when writing code that `fault` clauses need to be considered, separately from `finally` clauses. To do this, after importing EH clauses, convert any `BBJ_EHFINALLYRET` as necessary. Also, try/finally cloning, which (sometimes) converts `finally` clauses to `fault` clauses, needs to update the corresponding `BBJ_EHFINALLYRET`. When creating new try/fault clauses for synchronized functions, use `BBJ_EHFAULTRET` now. Fixes dotnet#84307
BruceForstall
added a commit
that referenced
this issue
Apr 7, 2023
The IL `endfinally` and `endfault` instructions are aliases, imported in the JIT IR as `BBJ_EHFINALLYRET`. Introduce `BBJ_EHFAULTRET` for cases within `fault` clauses. This simplifies some code, and makes it more clear when writing code that `fault` clauses need to be considered, separately from `finally` clauses. To do this, after importing EH clauses, convert any `BBJ_EHFINALLYRET` as necessary. Also, try/finally cloning, which (sometimes) converts `finally` clauses to `fault` clauses, needs to update the corresponding `BBJ_EHFINALLYRET`. When creating new try/fault clauses for synchronized functions, use `BBJ_EHFAULTRET` now. Fixes #84307
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The IL
endfaultopcode is an alias forendfinally. The JIT imports this as aBBJ_EHFINALLYRETBasicBlock type. It would be helpful to distinguish the block types so as not to require consulting the EH table when examining the block type to determine which type of EH handler we are in.So, consider adding a
BBJ_EHFAULTRETBasicBlock type and using it for exits from afaultregion.The text was updated successfully, but these errors were encountered: