Introduce BBJ_EHFAULTRET #84467
Merged
Introduce BBJ_EHFAULTRET #84467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue Detailsnull
|
The IL `endfinally` and `endfault` instructions are aliases, imported in the JIT IR as `BBJ_EHFINALLYRET`. Introduce `BBJ_EHFAULTRET` for cases within `fault` clauses. This simplifies some code, and makes it more clear when writing code that `fault` clauses need to be considered, separately from `finally` clauses. To do this, after importing EH clauses, convert any `BBJ_EHFINALLYRET` as necessary. Also, try/finally cloning, which (sometimes) converts `finally` clauses to `fault` clauses, needs to update the corresponding `BBJ_EHFINALLYRET`. When creating new try/fault clauses for synchronized functions, use `BBJ_EHFAULTRET` now. Fixes dotnet#84307
BruceForstall
force-pushed
the
IntroduceBBJ_EHFAULTRET
branch
from
278ce48
to
e3d0c5c
Compare
|
@AndyAyersMS PTAL |
|
There are asm diffs because we no longer mark non-argument GC vars that are live-out of a 'fault' handler as must-init. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IL
endfinallyandendfaultinstructions are aliases,imported in the JIT IR as
BBJ_EHFINALLYRET.Introduce
BBJ_EHFAULTRETfor cases withinfaultclauses.This simplifies some code, and makes it clearer when writing
code that
faultclauses need to be considered, separately fromfinallyclauses.To do this, after importing EH clauses, convert any
BBJ_EHFINALLYRETas necessary. Also, try/finally cloning, which (sometimes) converts
finallyclauses tofaultclauses, needs to update the correspondingBBJ_EHFINALLYRET. When creating new try/fault clauses for synchronizedfunctions, use
BBJ_EHFAULTRETnow.Fixes #84307