Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NativeAOT EventPipe require a reasonable random number generation to create guids #88789

Closed
LakshanF opened this issue Jul 12, 2023 · 1 comment · Fixed by #88838
Closed

NativeAOT EventPipe require a reasonable random number generation to create guids #88789

LakshanF opened this issue Jul 12, 2023 · 1 comment · Fixed by #88838
Assignees
@LakshanF
Labels
area-NativeAOT-coreclr
Milestone
8.0.0

Comments

@LakshanF
Copy link
Contributor

EventPipe require guids for activity_id. In non-windows, both mono and coreclr uses a random generation utility (coreclr one is here). NativeAOT has a random generation utility in thread that might cause some collisions with guids that get generated.
@LakshanF LakshanF added this to the 8.0.0 milestone Jul 12, 2023
@LakshanF LakshanF self-assigned this Jul 12, 2023
@ghost
Copy link

ghost commented Jul 12, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

EventPipe require guids for activity_id. In non-windows, both mono and coreclr uses a random generation utility (coreclr one is here). NativeAOT has a random generation utility in thread that might cause some collisions with guids that get generated.

Author: LakshanF
Assignees: LakshanF
Labels:

area-NativeAOT-coreclr
Milestone: 8.0.0

@LakshanF LakshanF mentioned this issue Jul 13, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 13, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LakshanF LakshanF

Labels
area-NativeAOT-coreclr
Projects
AppModel
Archived in project
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Generates a guid for activity id LakshanF/runtime
1 participant
@LakshanF