Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generates a guid for activity id #88838

Merged
merged 10 commits into from
Jul 26, 2023
Merged

Generates a guid for activity id #88838

merged 10 commits into from
Jul 26, 2023

Conversation

LakshanF
Copy link
Contributor

Calls CoCreateGuid on Windows and a random function for non-Windows. Also removes some stale @todos

Fixes #88789

@LakshanF LakshanF added this to the 8.0.0 milestone Jul 13, 2023
@LakshanF LakshanF requested a review from elinor-fung July 13, 2023 15:21
@LakshanF LakshanF self-assigned this Jul 13, 2023
@ghost
Copy link

ghost commented Jul 13, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Calls CoCreateGuid on Windows and a random function for non-Windows. Also removes some stale @todos

Fixes #88789

Author: LakshanF
Assignees: LakshanF
Labels:

area-NativeAOT-coreclr
Milestone: 8.0.0

@build-analysis build-analysis bot mentioned this pull request Jul 13, 2023
Closed
@LakshanF LakshanF requested a review from jkoritzinsky July 18, 2023 15:37
@build-analysis build-analysis bot mentioned this pull request Jul 18, 2023
Closed
This was referenced Jul 20, 2023
Closed
Closed
This was referenced Jul 21, 2023
Open
Closed
elinor-fung
elinor-fung reviewed Jul 21, 2023
View reviewed changes
src/native/minipal/configure.cmake Show resolved Hide resolved
src/native/minipal/random.h Outdated Show resolved Hide resolved
src/native/minipal/random.h Outdated Show resolved Hide resolved
src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp Outdated Show resolved Hide resolved
src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp Show resolved Hide resolved
@LakshanF LakshanF merged commit 254263f into dotnet:main Jul 26, 2023
@LakshanF LakshanF deleted the RandomGuids branch July 26, 2023 09:19
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@teo-tsirpanis teo-tsirpanis teo-tsirpanis left review comments

@jkotas jkotas jkotas left review comments

@danmoseley danmoseley danmoseley left review comments

@jkoritzinsky jkoritzinsky jkoritzinsky left review comments

@elinor-fung elinor-fung elinor-fung approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@LakshanF LakshanF

Labels
area-NativeAOT-coreclr
Projects
AppModel
Status: Done
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

NativeAOT EventPipe require a reasonable random number generation to create guids
6 participants
@LakshanF @jkoritzinsky @danmoseley @jkotas @teo-tsirpanis @elinor-fung