Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NativeAOT] Add appropriate telemetry flags to track use of NativeAOT on iOS-like platforms #88844

Closed
Tracked by #80905
ivanpovazan opened this issue Jul 13, 2023 · 2 comments · Fixed by #90208
Closed
Tracked by #80905
Assignees
Milestone

Comments

@ivanpovazan
Copy link
Member

@steveisok please add more context if necessary, thank you!

@ghost
Copy link

ghost commented Jul 13, 2023

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

@steveisok please add more context if necessary, thank you!

Author: ivanpovazan
Assignees: steveisok
Labels:

os-ios, area-NativeAOT-coreclr

Milestone: 8.0.0

@steveisok
Copy link
Member

Our current state is that we would only get telemetry numbers for NativeAOT during dotnet publish. That is not something iOS does by default.

https://github.com/dotnet/sdk/blob/676d07949d868756967172ceaa7494bb2317cd15/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Publish.targets#L91-L95

@agocke agocke added this to AppModel Aug 9, 2023
@agocke agocke modified the milestones: 8.0.0, 9.0.0 Aug 10, 2023
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 10, 2023
steveisok added a commit that referenced this issue Aug 12, 2023
This change adds CLI telemetry for common mobile and wasm scenarios.

Total app size is another element we plan on tracking and that will be added in a follow up.

Fixes #88844
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 12, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants