Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure JIT/Methodical/int64/superlong/superlong_d/superlong_d.dll #93710

Closed
v-wenyuxu opened this issue Oct 19, 2023 · 4 comments · Fixed by #93897
Closed

Test failure JIT/Methodical/int64/superlong/superlong_d/superlong_d.dll #93710

v-wenyuxu opened this issue Oct 19, 2023 · 4 comments · Fixed by #93897
Assignees
@AndyAyersMS
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs os-windows
Milestone
9.0.0

Comments

@v-wenyuxu
Copy link

Failed in: runtime-coreclr outerloop 20231018.3

Failed tests:

R2R-CG2 windows x64 Checked @ Windows.10.Amd64.Open
    - JIT/Methodical/int64/superlong/superlong_d/superlong_d.dll
    - JIT/Methodical/int64/superlong/superlong_il_d/superlong_il_d.dll
    - JIT/Methodical/int64/superlong/superlong_r/superlong_r.dll
R2R-CG2 windows x64 Checked no_tiered_compilation @ Windows.10.Amd64.Open
    - JIT/Methodical/int64/superlong/superlong_d/superlong_d.dll
    - JIT/Methodical/int64/superlong/superlong_il_d/superlong_il_d.dll
    - JIT/Methodical/int64/superlong/superlong_r/superlong_r.dll

Error message:

Object reference not set to an instance of an object.

Stack trace:

   at JitTest_superlong_cs.superlong.add(superlong op1, superlong op2)
   at JitTest_superlong_cs.superlong.TestEntryPoint()
   at Program.<<Main>$>g__TestExecutor239|0_240(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&)
@v-wenyuxu v-wenyuxu added os-windows arch-x64 blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs labels Oct 19, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 19, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 19, 2023
@ghost
Copy link

ghost commented Oct 19, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Failed in: runtime-coreclr outerloop 20231018.3

Failed tests:

R2R-CG2 windows x64 Checked @ Windows.10.Amd64.Open
    - JIT/Methodical/int64/superlong/superlong_d/superlong_d.dll
    - JIT/Methodical/int64/superlong/superlong_il_d/superlong_il_d.dll
    - JIT/Methodical/int64/superlong/superlong_r/superlong_r.dll
R2R-CG2 windows x64 Checked no_tiered_compilation @ Windows.10.Amd64.Open
    - JIT/Methodical/int64/superlong/superlong_d/superlong_d.dll
    - JIT/Methodical/int64/superlong/superlong_il_d/superlong_il_d.dll
    - JIT/Methodical/int64/superlong/superlong_r/superlong_r.dll

Error message:

Object reference not set to an instance of an object.

Stack trace:

   at JitTest_superlong_cs.superlong.add(superlong op1, superlong op2)
   at JitTest_superlong_cs.superlong.TestEntryPoint()
   at Program.<<Main>$>g__TestExecutor239|0_240(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&)
Author: v-wenyuxu
Assignees: -
Labels:

os-windows, arch-x64, area-CodeGen-coreclr, blocking-outerloop
Milestone: -

@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Oct 20, 2023
@JulieLeeMSFT JulieLeeMSFT added this to the 9.0.0 milestone Oct 20, 2023
@JulieLeeMSFT
Copy link
Member

HI @jakobbotsch, PTAL this blocking outerloop issue.

@jakobbotsch
Copy link
Member

@AndyAyersMS This looks caused by #93371. The JIT fails to allocate outgoing arg space even though there is a call to a throw helper. Can you take a look?

@AndyAyersMS
Copy link
Member

Yes, I'll take a look.

AndyAyersMS added a commit to AndyAyersMS/runtime that referenced this issue Oct 23, 2023
@AndyAyersMS
JIT: fix bug introduced by recent throw helper block changes
5f75881 
`compUsesThrowHelper` indicates codegen will likely need to create a call to a helper,
whether or not such calls are shared.

In dotnet#93371 I didn't appreciate this, and so the JIT was failing to set `compUsesThrowHelper`
in cases where a throw helper was going to be needed but throw helper calls were not going to
be shared.

Fixes dotnet#93710.
@AndyAyersMS AndyAyersMS mentioned this issue Oct 23, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 23, 2023
AndyAyersMS added a commit that referenced this issue Oct 24, 2023
@AndyAyersMS
JIT: fix bug introduced by recent throw helper block changes (#93897)
a270140 
`compUsesThrowHelper` indicates codegen will likely need to create a call to a helper,
whether or not such calls are shared.

In #93371 I didn't appreciate this, and so the JIT was failing to set `compUsesThrowHelper`
in cases where a throw helper was going to be needed but throw helper calls were not going to
be shared.

Fixes #93710.
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 24, 2023
liveans pushed a commit to liveans/dotnet-runtime that referenced this issue Nov 9, 2023
@AndyAyersMS @liveans
JIT: fix bug introduced by recent throw helper block changes (dotnet#…
8e82e06 
…93897)

`compUsesThrowHelper` indicates codegen will likely need to create a call to a helper,
whether or not such calls are shared.

In dotnet#93371 I didn't appreciate this, and so the JIT was failing to set `compUsesThrowHelper`
in cases where a throw helper was going to be needed but throw helper calls were not going to
be shared.

Fixes dotnet#93710.
@ghost ghost locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AndyAyersMS AndyAyersMS

Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs os-windows
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

JIT: fix bug introduced by recent throw helper block changes AndyAyersMS/runtime
4 participants
@jakobbotsch @AndyAyersMS @JulieLeeMSFT @v-wenyuxu