JIT: fix bug introduced by recent throw helper block changes #93897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`compUsesThrowHelper` indicates codegen will likely need to create a call to a helper, whether or not such calls are shared. In dotnet#93371 I didn't appreciate this, and so the JIT was failing to set `compUsesThrowHelper` in cases where a throw helper was going to be needed but throw helper calls were not going to be shared. Fixes dotnet#93710.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Details
In #93371 I didn't appreciate this, and so the JIT was failing to set Fixes #93710.
|
|
FYI @dotnet/jit-contrib |
12 tasks
jakobbotsch
approved these changes
Oct 24, 2023
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Outlerloop was green. |
liveans
pushed a commit
to liveans/dotnet-runtime
that referenced
this pull request
Nov 9, 2023
…93897) `compUsesThrowHelper` indicates codegen will likely need to create a call to a helper, whether or not such calls are shared. In dotnet#93371 I didn't appreciate this, and so the JIT was failing to set `compUsesThrowHelper` in cases where a throw helper was going to be needed but throw helper calls were not going to be shared. Fixes dotnet#93710.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compUsesThrowHelperindicates codegen will likely need to create a call to a helper, whether or not such calls are shared.In #93371 I didn't appreciate this, and so the JIT was failing to set
compUsesThrowHelperin cases where a throw helper was going to be needed but throw helper calls were not going to be shared.Fixes #93710.