[InlineArray] should not have [EditorBrowsableState(Never)]

[Sergio0694]

Description

The [InlineArray] type is marked with [EditorBrowsable(EditorBrowsableState.Never)]:

runtime/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/InlineArrayAttribute.cs

Lines 11 to 13 in 655b177

	[EditorBrowsable(EditorBrowsableState.Never)]
	[AttributeUsage(AttributeTargets.Struct, AllowMultiple = false)]
	public sealed class InlineArrayAttribute : Attribute

This seems... Wrong? There's no built-in C# syntax for inline arrays for now, so the attribute has to be used explicitly in user code. The fact it's hidden makes this clunkier than it needs to be. The attribute is already buried in a namespace that's explicitly documented as "unsafe" and only for advanced users, so this feels unnecessary.

Shouldn't we just remove this?
And if so, I take it the ship has sailed for .NET 8 GA at this point?

[ghost]

Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

The [InlineArray] type is marked with [EditorBrowsable(EditorBrowsableState.Never)]:

runtime/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/InlineArrayAttribute.cs

Lines 11 to 13 in 655b177

	[EditorBrowsable(EditorBrowsableState.Never)]
	[AttributeUsage(AttributeTargets.Struct, AllowMultiple = false)]
	public sealed class InlineArrayAttribute : Attribute

This seems... Wrong? There's no built-in C# syntax for inline arrays for now, so the attribute has to be used explicitly in user code. The fact it's hidden makes this clunkier than it needs to be. The attribute is already buried in a namespace that's explicitly documented as "unsafe" and only for advanced users, so this feels unnecessary.

Shouldn't we just remove this?
And if so, I take it the ship has sailed for .NET 8 GA at this point?

Author:	Sergio0694
Assignees:	-
Labels:	area-System.Runtime.CompilerServices, untriaged
Milestone:	-

[MichalStrehovsky]

Cc @VSadov - I can't find where the EditorBrowsable came from. I don't see the API review mentioning this.

[stephentoub]

Shouldn't we just remove this?

Yes, this should not be EditorBrowsableState.Never. We should remove it, and ideally service that for 8.

[Sergio0694]

Happy to take this and make a PR if this is up for grabs. I can also add the missing XML docs while at it 🙂

[tannergooding]

@Sergio0694, assigned to you

[VSadov]

I think the attribute was simply copied from other similar types when we still had assumptions that users will not need to put the attribute directly in the code, but instead compilers would emit it when implementing inline-array-like features.
In the final design of the feature on C# side there is indeed no special syntax to declare inline array types and thus it requires using the attribute.

@Sergio0694 Thanks for fixing this!!