Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove [EditorBrowsable(Never)] from [InlineArray], add XML docs #94308

Merged

Conversation

Sergio0694
Copy link
Contributor

Closes #94283

Overview

This PR includes two changes to [InlineArray]:

  • Removes [EditorBrowsable(EditorBrowsableState.Never)]
  • Adds some XML remarks, as well as all missing XML docs

Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 2, 2023
@ghost
Copy link

ghost commented Nov 2, 2023

Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #94283

Overview

This PR includes two changes to [InlineArray]:

  • Removes [EditorBrowsable(EditorBrowsableState.Never)]
  • Adds some XML remarks, as well as all missing XML docs
Author: Sergio0694
Assignees: -
Labels:

area-System.Runtime.CompilerServices, new-api-needs-documentation

Milestone: -

Co-authored-by: Stephen Toub <stoub@microsoft.com>
@stephentoub
Copy link
Member

Thanks.

@stephentoub stephentoub merged commit 80666e8 into dotnet:main Nov 3, 2023
@stephentoub
Copy link
Member

/backport to release/8.0-staging

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/6746152329

@Sergio0694 Sergio0694 deleted the user/sergiopedri/inline-array-visible branch November 3, 2023 14:15
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[InlineArray] should not have [EditorBrowsableState(Never)]
2 participants