-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] Remove [EditorBrowsable(Never)] from [InlineArray], add XML docs #94343
[release/8.0-staging] Remove [EditorBrowsable(Never)] from [InlineArray], add XML docs #94343
Conversation
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices Issue DetailsBackport of #94308 to release/8.0-staging Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
Friendly reminder: If you'd like this to be included in the December release, please merge it before Tuesday November 14th EOD (Code Complete). |
@stephentoub, is there anything blocking this from being merged given its marked as |
I just didn't remember whether I was supposed to merge or wait for Carlos. |
Plus someone needs to approve it. |
Does this require we update the ref pack to update intellisense, and do we generally do that for servicing? |
I'm not concerned about the IntelliSense changes; they just came along for the ride. But presumably the ref pack needs to be updated for the ref assembly to pick up the removed attribute, and I believe we do update the ref pack in servicing... isn't that how we end up distributing source generators? |
Backport of #94308 to release/8.0-staging
/cc @stephentoub @Sergio0694
Customer Impact
[InlineArray] is a new feature we would like developers to use, but it's currently hidden from IntelliSense due to an errant attribute on the type. This just removes the attribute so that the type shows up in the IDE when a developer tries to use it.
Testing
There's no functional impact to the change.
Risk
As low as it gets.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging
, notrelease/X.0
.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.