Update some of NativeAOT's uses of Lock to use non-alertable waits #97105
Comments
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsBased on discussion in #94873. Alertable waits can be overridden by SynchronizationContext, are interruptible, and can be reentrant on some threads. Update some low-level uses of Lock such as in class construction to use non-alertable waits.
|
kouvel
added a commit
to kouvel/runtime
that referenced
this issue
Jan 19, 2024
- Added an internal constructor that enables the lock to use non-alertable waits - Non-alertable waits are not forwarded to `SynchronizationContext` wait overrides, are non-message-pumping waits, and are not interruptible - Updated most of the uses of `Lock` in NativeAOT to use non-alertable waits - Also simplified the fix in dotnet#94873 to avoid having to do the relevant null checks in various places along the wait path, by limiting the scope of the null checks to the initialization phase Fixes dotnet#97105
ghost
added
the
in-pr
kouvel
added a commit
that referenced
this issue
Jan 24, 2024
…7227) * Add an internal mode to `Lock` to have it use trivial (non-alertable) waits - Added an internal constructor that enables the lock to use trivial waits - Trivial waits are non-alertable waits that are not forwarded to `SynchronizationContext` wait overrides, are non-message-pumping waits, and are not interruptible - Updated most of the uses of `Lock` in NativeAOT to use trivial waits - Also simplified the fix in #94873 to avoid having to do the relevant null checks in various places along the wait path, by limiting the scope of the null checks to the initialization phase Fixes #97105
ghost
removed
the
in-pr
|
Reverted by #98867 |
ghost
added
the
in-pr
ghost
removed
the
in-pr
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Based on discussion in #94873. Alertable waits can be overridden by SynchronizationContext, are interruptible, and can be reentrant on some threads. Update some low-level uses of Lock such as in class construction to use non-alertable waits.
The text was updated successfully, but these errors were encountered: