Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -cross flag to build.ps1 #100678

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Add -cross flag to build.ps1 #100678

merged 1 commit into from
Apr 5, 2024

Conversation

akoeplinger
Copy link
Member

Fixes VMR build error on Windows after dotnet/installer#19321

We haven't used or passed this on Windows before and a bunch of logic is conditioned based on the CrossBuild property (which is what -cross is turned into in build.sh) so ignore it for now.

Fixes VMR build error on Windows after dotnet/installer#19321

We haven't used or passed this on Windows before and a bunch of logic is conditioned based on the `CrossBuild` property (which is what `-cross` is turned into in build.sh) so ignore it for now.
@akoeplinger akoeplinger requested a review from ViktorHofer April 5, 2024 14:05
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 5, 2024
@teo-tsirpanis teo-tsirpanis added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 5, 2024
@akoeplinger
Copy link
Member Author

/ba-g windows legs passed, the non-windows legs can't be affected.

@akoeplinger akoeplinger merged commit d79a753 into main Apr 5, 2024
142 of 152 checks passed
@akoeplinger akoeplinger deleted the akoeplinger-patch-1 branch April 5, 2024 16:14
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
Fixes VMR build error on Windows after dotnet/installer#19321

We haven't used or passed this on Windows before and a bunch of logic is conditioned based on the `CrossBuild` property (which is what `-cross` is turned into in build.sh) so ignore it for now.
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants