[VMR] Pass target architecture on Windows #19321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't pass an explicit architecture so it always used the host one, even for arm64/x86 builds. Contributes to dotnet/source-build#4292
ViktorHofer
approved these changes
Apr 5, 2024
|
Should we also pass the TargetOS in, in case we would ever want to cross-build on Windows, i.e. for Browser? |
|
Yeah good idea. |
|
/azp run installer-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks. Do we have a tracking issue for the |
|
Ugh I should have disabled auto-merge ... I think |
3 tasks
akoeplinger
added a commit
to dotnet/runtime
that referenced
this pull request
Apr 5, 2024
Fixes VMR build error on Windows after dotnet/installer#19321 We haven't used or passed this on Windows before and a bunch of logic is conditioned based on the `CrossBuild` property (which is what `-cross` is turned into in build.sh) so ignore it for now.
akoeplinger
added a commit
to dotnet/runtime
that referenced
this pull request
Apr 5, 2024
Fixes VMR build error on Windows after dotnet/installer#19321 We haven't used or passed this on Windows before and a bunch of logic is conditioned based on the `CrossBuild` property (which is what `-cross` is turned into in build.sh) so ignore it for now.
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
Fixes VMR build error on Windows after dotnet/installer#19321 We haven't used or passed this on Windows before and a bunch of logic is conditioned based on the `CrossBuild` property (which is what `-cross` is turned into in build.sh) so ignore it for now.
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
Fixes VMR build error on Windows after dotnet/installer#19321 We haven't used or passed this on Windows before and a bunch of logic is conditioned based on the `CrossBuild` property (which is what `-cross` is turned into in build.sh) so ignore it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't pass an explicit architecture so it always used the host one, even for arm64/x86 builds.
Contributes to dotnet/source-build#4292