Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows legs in dotnet-unified-build all have the same minimal command line #4292

Closed
jtschuster opened this issue Apr 4, 2024 · 4 comments
Closed

Windows legs in dotnet-unified-build all have the same minimal command line #4292

jtschuster opened this issue Apr 4, 2024 · 4 comments
Labels
area-unified-build

Comments

@jtschuster
Copy link
Member

jtschuster commented Apr 4, 2024 •
edited
Loading

All the Windows builds have the same command line:
call D:\a\_work\1\s\build.cmd -ci -cleanWhileBuilding -prepareMachine

https://dnceng.visualstudio.com/internal/_build/results?buildId=2421402&view=logs&j=89eea50f-59b5-5921-c3ce-ce40b36fa819&t=031b42e3-5aa0-5997-c17d-4c3a65357561&l=11
@jtschuster jtschuster changed the title Windows_arm64 leg in dotnet-unified-build sets TargetRid=win-x64 Windows legs in dotnet-unified-build all have the same minimal command line Apr 4, 2024
@ViktorHofer
Copy link
Member

See https://github.com/dotnet/installer/blob/51def0db9d41b06649148d03cfc93d23f49ed418/eng/pipelines/templates/jobs/vmr-build.yml#L241

Looks like Windows is missing at least TargetArchitecture but probably more.

akoeplinger added a commit to dotnet/installer that referenced this issue Apr 5, 2024
@akoeplinger
[VMR] Pass target architecture on Windows
9d33562 
We didn't pass an explicit architecture so it always used the host one, even for arm64/x86 builds.

Contributes to dotnet/source-build#4292
@akoeplinger akoeplinger mentioned this issue Apr 5, 2024
Merged
@akoeplinger
Copy link
Member

dotnet/installer#19321 adds the target arch, I compared the parameters with the Linux logic and the only other thing missing from what I can see is handling useMonoRuntime /cc @directhex

akoeplinger added a commit to dotnet/installer that referenced this issue Apr 5, 2024
@akoeplinger
[VMR] Pass target architecture and OS on Windows (#19321)
caadf5c 
We didn't pass an explicit architecture so it always used the host one, even for arm64/x86 builds.

Contributes to dotnet/source-build#4292
@mmitche
Copy link
Member

mmitche commented Jan 6, 2025

@akoeplinger @ViktorHofer Still valid? If not, please close

@ViktorHofer
Copy link
Member

This got fixed on the YML side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-unified-build
Projects
.NET Unified Build
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@akoeplinger @ViktorHofer @MichaelSimons @mmitche @jtschuster