Skip to content

Conversation

MichalStrehovsky
Copy link
Member

No description provided.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 12, 2024
Comment on lines +14 to +15
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly" Version="9.0.0-preview.3.24172.13" />
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly.DevServer" Version="9.0.0-preview.3.24172.13" PrivateAssets="all" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an issue that tracks removing these hardcodes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an issue that tracks removing these hardcodes?

Might want to ask that @radekdoulik @maraf @pavelsavara who were involved in the PR that introduced it; looks like this has been causing extra work when bumping the SDK since 8.0 RC1.

@MichalStrehovsky MichalStrehovsky added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 15, 2024
@MichalStrehovsky
Copy link
Member Author

Looks like the new run is hitting a hard crash in the runtime on osx-x64. I doubt it was caused by the latest commit, so this is one of those fun non-deterministic crashes in MSBuild:

2024-04-15T09:34:59.7728930Z     /Users/runner/work/1/s/dotnet.sh: line 27: 91742 Segmentation fault: 11  ${dotnetPath} "$@"
2024-04-15T09:34:59.8872770Z /Users/runner/work/1/s/src/tests/JIT/HardwareIntrinsics/Arm/Directory.Build.targets(15,5): error MSB3073: The command ""/Users/runner/work/1/s/dotnet.sh" build /Users/runner/work/1/s//src/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.csproj -c Release --no-restore /p:IntermediateOutputPath=/Users/runner/work/1/s/artifacts/tests/coreclr/obj/osx.x64.Release/Managed/JIT/HardwareIntrinsics/Arm/Sve/Sve_r//GenerateHWIntrinsicTests/ /p:OutputPath=/Users/runner/work/1/s/artifacts/tests/coreclr/osx.x64.Release/JIT/HardwareIntrinsics/Arm/Sve/Sve_r//GenerateHWIntrinsicTests/" exited with code 139. [/Users/runner/work/1/s/src/tests/JIT/HardwareIntrinsics/Arm/Sve/Sve_r.csproj] [/Users/runner/work/1/s/src/tests/build.proj]

I guess this is now NO-MERGE/blocked. Filed #101049.

@akoeplinger
Copy link
Member

akoeplinger commented Apr 15, 2024

Doesn't seem related given we found more hits in older releases in #101049 so I triggered a rerun.

@am11
Copy link
Member

am11 commented Apr 15, 2024

All green after the rerun. :shipit:

@ViktorHofer ViktorHofer merged commit dd7c82e into main Apr 15, 2024
@ViktorHofer ViktorHofer deleted the MichalStrehovsky-patch-1 branch April 15, 2024 16:08
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
* Update global.json

* Update blazor.csproj

* Delete useless `RuntimeIdentifiers`

* Fix up illinker tests

* Fix two more preview1 versions

---------

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants