Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch AOT compilers to use AssemblyNameInfo #102036

Merged
merged 2 commits into from
May 10, 2024
Merged

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented May 9, 2024

Avoids dependency on AssemblyName.Culture and globalization (ICU)

Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once tests pass, thank you!

@jkotas
Copy link
Member Author

jkotas commented May 9, 2024

/azp run runtime-nativeaot-outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas jkotas merged commit aa4b0ab into dotnet:main May 10, 2024
98 of 108 checks passed
@jkotas jkotas deleted the assemblynameinfo branch May 10, 2024 00:56
MichalStrehovsky added a commit that referenced this pull request May 10, 2024
With #102036 this should just work and speed up compilation/make compiler NuGet smaller.
jkotas pushed a commit that referenced this pull request May 10, 2024
With #102036 this should just work and speed up compilation/make compiler NuGet smaller.
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
With dotnet#102036 this should just work and speed up compilation/make compiler NuGet smaller.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants