Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the definition of RhGetCurrentThunkContext #102395

Merged
merged 1 commit into from
May 18, 2024
Merged

Fix the definition of RhGetCurrentThunkContext #102395

merged 1 commit into from
May 18, 2024

Conversation

SingleAccretion
Copy link
Contributor

This is an FCall - FCalls need FCIMPL-based calling convention munging.

Discovered downstream: dotnet/runtimelab#2587.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 17, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented May 17, 2024

/azp run runtime-nativeaot-outerloop

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SingleAccretion SingleAccretion marked this pull request as ready for review May 18, 2024 07:27
@SingleAccretion
Copy link
Contributor Author

Build linux_musl-x64 Release NativeAOT_Libs failure looks a bit like #100441.

jkotas
jkotas approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 0d8c6b7 into dotnet:main May 18, 2024
106 of 108 checks passed
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@SingleAccretion @Ruihan-Yin
Fix the definition of RhGetCurrentThunkContext (dotnet#102395)
3dcdd85
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
@SingleAccretion SingleAccretion deleted the RhGetCurrentThunkContext branch July 14, 2024 11:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees
No one assigned
Labels
area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SingleAccretion @jkotas