Consistent ConfigureAwait on Loopback, RemoteExecutor.DisposeAsync #102699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liveans
added
NO-MERGE
|
Tagging subscribers to this area: @dotnet/ncl |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced May 27, 2024
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced May 27, 2024
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime |
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
antonfirsov
reviewed
Jun 2, 2024
src/libraries/Common/tests/System/Net/RemoteExecutorExtensions.cs
Outdated
Show resolved
Hide resolved
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
CarnaViire
reviewed
Jun 3, 2024
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs
Outdated
Show resolved
Hide resolved
liveans
changed the title
liveans
changed the title
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@CarnaViire @ManickaP I'll merge this as soon as CI finishes to run (if there are no related failures ofc). Are there any further concerns with this PR? Any other CI run you want to see? |
ManickaP
approved these changes
Jun 3, 2024
src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.AltSvc.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is doing couple of stuff:
ConfigureAwait(false)more consistently on Http3Loopback(Server/Connection/Stream) classes.